Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOD flaky test #1443

Open
Derrick2000 opened this issue Nov 20, 2024 · 0 comments · May be fixed by #1444
Open

NOD flaky test #1443

Derrick2000 opened this issue Nov 20, 2024 · 0 comments · May be fixed by #1444
Labels
Test

Comments

@Derrick2000
Copy link

Derrick2000 commented Nov 20, 2024 •
edited
Loading

Describe the bug

I've been working with the Issue256Test class in your repository and wanted to address some flakiness I observed in the tests runReconnectSocketClose and runReconnectCloseBlocking. These tests were intermittently failing (detected by iDFlakies due to shared state and improper resource management, leading to Non-Order-Deterministic (NOD) flakiness.

To Reproduce
Steps to reproduce the behavior:

  1. Set up iDFlakies
  2. mvn install -am -DskipTests
  3. mvn edu.illinois.cs:idflakies-maven-plugin:2.0.0:detect -Ddt.randomize.rounds=10 -Ddt.detector.original_order.all_must_pass=false
  4. Read the output file "failing-test-output..."
  5. You should see
    Detected incompatible test case (org.java_websocket.issues.Issue256Test.runReconnectSocketClose)
    Detected incompatible test case (org.java_websocket.issues.Issue256Test.runReconnectCloseBlocking)
    indicating NOD flakiness

Additional context
I will submit a PR addressing this issue
@Derrick2000 Derrick2000 linked a pull request Nov 20, 2024 that will close this issue
Open
8 tasks
@marci4 marci4 added the Test label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix NOD flaky test Derrick2000/Java-WebSocket
2 participants
@marci4 @Derrick2000