Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n support? #84

Open
kiridaruma opened this issue Jan 31, 2020 · 3 comments
Open

i18n support? #84

kiridaruma opened this issue Jan 31, 2020 · 3 comments

Comments

@kiridaruma
Copy link

SHACL validate result has sh:resultMessage. but its message only English now.

I think to need be able to pluggable for support i18n. but message is hardcoded now.

https://github.com/TopQuadrant/shacl/blob/master/src/main/java/org/topbraid/shacl/validation/java/AbstractClusiveConstraintExecutor.java

@HolgerKnublauch
Copy link
Collaborator

Yes I agree this needs to be addressed. I will keep the ticket open. Thanks.

@ashleycaselli
Copy link
Collaborator

@kiridaruma I created and linked a branch to this issue. Please, do not hesitate to propose possible solutions if you have something in mind already.

Let's see how @HolgerKnublauch sees this. In my opinion, the solution should be a pluggable one. In other words, I would like to avoid including "all the possible" language files in the library and rather provide a way for plug&play the desired external language file/s.

@kiridaruma
Copy link
Author

I'm sorry. I'd forgot this issue.
I don't have any code now. however I aggree to @ashleycaselli comment that "the solution should be a pluggable one."

I think it needs some argument that multiple language comment include to this repository or not.
My opinion is

  • include some language comment data to this repository.
  • but provide pluggable interface from outside.

any question or comment?

FYI, my 1st language is Japanese. I can write Japanese comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants