Component search upgrades #7314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
updated: #7315 |
vder
force-pushed
the
component-search-upgrades
branch
from
e172450 to
023d0a2
Compare
gskrobisz
reviewed
Dec 12, 2024
|
|
||
| type SelectorResult = { expression: string } | string; | ||
| type Selector = (node: NodeType) => SelectorResult | SelectorResult[]; | ||
| type FilterSelector = { name: string; selector: Selector }[]; | ||
|
|
||
| const fieldsSelectors: FilterSelector = [ | ||
| { | ||
| name: "id", | ||
| name: "name", | ||
|
|
lciolecki
reviewed
Dec 12, 2024
| @@ -40,7 +40,7 @@ export function AdvancedSearchFilters({ | |||
|
|
|||
| const displayNames = useMemo( | |||
| () => ({ | |||
| id: t("panels.search.field.id", "Name"), | |||
| name: t("panels.search.field.id", "Name"), | |||
There was a problem hiding this comment.
panels.search.field.id -> panels.search.field.name?
lciolecki
reviewed
Dec 12, 2024
| description?: string[]; | ||
| type?: string[]; | ||
| componentGroup?: string[]; |
There was a problem hiding this comment.
As I remember we don't need it?
lciolecki
reviewed
Dec 12, 2024
| @@ -94,13 +121,13 @@ export function useFilteredNodes(searchQuery: SearchQuery): { | |||
|
|
|||
| const displayNames = useMemo( | |||
| () => ({ | |||
| id: t("panels.search.field.id", "Name"), | |||
| name: t("panels.search.field.id", "Name"), | |||
There was a problem hiding this comment.
panels.search.field.id -> panels.search.field.name
lciolecki
reviewed
Dec 12, 2024
|
|
||
| return useMemo(() => { | ||
| return new Set( | ||
| componentsGroups.flatMap((componentGroup) => componentGroup.components).map((component) => component.label.toLowerCase()), |
There was a problem hiding this comment.
Do we need component group?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
some adjustments in advanced search toolbar:
idtonamein search stringChecklist before merge