Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies: Netty, HikariCP, HSQLDB #7331

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

Update dependencies: Netty, HikariCP, HSQLDB #7331

wants to merge 2 commits into from

Conversation

piotrp
Copy link
Member

@piotrp piotrp commented Dec 13, 2024

Describe your changes

Checklist before merge

  • Related issue ID is placed at the beginning of PR title in [brackets] (can be GH issue or Nu Jira issue)
  • Code is cleaned from temporary changes and commented out lines
  • Parts of the code that are not easy to understand are documented in the code
  • Changes are covered by automated tests
  • Showcase in dev-application.conf added to demonstrate the feature
  • Documentation added or updated
  • Added entry in Changelog.md describing the change from the perspective of a public distribution user
  • Added MigrationGuide.md entry in the appropriate subcategory if introducing a breaking change
  • Verify that PR will be squashed during merge

@piotrp piotrp marked this pull request as ready for review December 13, 2024 13:26
arkadius
arkadius reviewed Dec 13, 2024
View reviewed changes
scenario-compiler/src/main/scala/pl/touk/nussknacker/engine/testing/ModelJarBuilder.scala
import scala.reflect.ClassTag
import scala.util.Using

object ModelJarBuilder {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

U guess that it wasn't used anywhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no comment stating that it's needed in an external project, and the last use site in Nu was removed two years ago, in 481dc6d

@piotrp piotrp enabled auto-merge (rebase) December 13, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arkadius arkadius arkadius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotrp @arkadius