Skip to content

Commit 0f5322d

Browse files
硬编码路径优化完成 (#117)
已成功完成对硬编码路径的参数化优化。 ## 修改内容 **文件:** `rule/datapack.bzl` **变更:** 将第383行的硬编码路径 `data/minecraft/tags/functions` 参数化 - 添加了两个局部常量 `_MINECRAFT_TAGS_FUNCTIONS_PREFIX` 和 `_MINECRAFT_TAGS_FUNCTION_STRIP_PREFIX` - 更新了 `pkg_files` 调用,使用变量替代硬编码字符串 - 保持了与原有 `strip_prefix` 路径的一致性 **具体变更:** ```python # 定义 Minecraft 标签路径常量 _MINECRAFT_TAGS_FUNCTIONS_PREFIX = "data/minecraft/tags/functions" _MINECRAFT_TAGS_FUNCTION_STRIP_PREFIX = "data/minecraft/tags/function" pkg_files( name = name + "_function_tag_legacy", visibility = visibility, srcs = [":%s_function_tag_legacy_compress" % name], prefix = _MINECRAFT_TAGS_FUNCTIONS_PREFIX, strip_prefix = _MINECRAFT_TAGS_FUNCTION_STRIP_PREFIX, ) ``` ## 验证结果 - ✅ 语法检查通过:`bazel query` 验证目标存在 - ✅ 构建测试通过:`bazel build //subprojects/stone-disappearance:stone-disappearance` 成功构建 - ✅ 无破坏性变更:现有构建流程保持不变 ## 优化效果 1. **提高可维护性**:路径集中管理,未来修改只需更新常量 2. **提升代码清晰度**:使用有意义的变量名替代魔术字符串 3. **保持向后兼容**:不改变现有构建行为,所有数据包构建不受影响 本次优化完成了 Issue 中提出的低优先级改进要求,使构建系统代码更加健壮和可维护。 Closes #115 <a href="https://opencode.ai/s/kU1AGstn"><img width="200" alt="New%20session%20-%202026-01-24T17%3A05%3A59.768Z" src="https://social-cards.sst.dev/opencode-share/TmV3IHNlc3Npb24gLSAyMDI2LTAxLTI0VDE3OjA1OjU5Ljc2OFo=.png?model=deepseek/deepseek-reasoner&version=1.1.34&id=kU1AGstn" /></a> [opencode session](https://opencode.ai/s/kU1AGstn)&nbsp;&nbsp;|&nbsp;&nbsp;[github run](/TouchController/E1epack/actions/runs/21318552264)
2 parents 607dcd3 + 92ada0d commit 0f5322d

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

rule/datapack.bzl

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -394,12 +394,16 @@ def _datapack_impl(
394394
srcs = function_tags,
395395
)
396396

397+
# 定义 Minecraft 标签路径常量
398+
_MINECRAFT_TAGS_FUNCTIONS_PREFIX = "data/minecraft/tags/functions"
399+
_MINECRAFT_TAGS_FUNCTION_STRIP_PREFIX = "data/minecraft/tags/function"
400+
397401
pkg_files(
398402
name = name + "_function_tag_legacy",
399403
visibility = visibility,
400404
srcs = [":%s_function_tag_legacy_compress" % name],
401-
prefix = "data/minecraft/tags/functions",
402-
strip_prefix = "data/minecraft/tags/function",
405+
prefix = _MINECRAFT_TAGS_FUNCTIONS_PREFIX,
406+
strip_prefix = _MINECRAFT_TAGS_FUNCTION_STRIP_PREFIX,
403407
)
404408

405409
pkg_filegroup(

0 commit comments

Comments
 (0)