Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise river-port placements #64

Open
Goosius1 opened this issue Jul 5, 2023 · 0 comments
Open

Revise river-port placements #64

Goosius1 opened this issue Jul 5, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Goosius1
Copy link
Collaborator

Goosius1 commented Jul 5, 2023

  • Currently placing a river port checks for the biome, but it decides how to check based on the "check by block" config, which is quite messy.
  • In addition, it always looks in the middle of the chunk, which is not super clever, because the river might not be there
  • To fix these issues:
    • First, maybe check all the surface blocks for a river... Or check where the player is standing. We'd have to do the same thing for ocean port placements.
    • As for the biome, perhaps just remove that config entirely, and always try to use the block biome. If that doesn't work in the wild, we may have to re-add the config back for placement scanning. I saw that valoria were getting incorrect biome info at one point but......I suspect that is actually because they had not switched the config to the right settings. I think getting it by block might work all round
    • As for the land validation job, let that always use the material check anyway, as its entirely reliable.
@Goosius1 Goosius1 added the bug Something isn't working label Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant