Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a user preference that can be used as a fallback for the sender a… #2744

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add a user preference that can be used as a fallback for the sender a… #2744

wants to merge 4 commits into from

Conversation

ZeiP
Copy link
Member

@ZeiP ZeiP commented Feb 22, 2022

…uthentication.

@ZeiP
Copy link
Member Author

ZeiP commented Feb 22, 2022 •
edited
Loading

  • TODO: Check if it handles correctly a case where the mode is 'to' but no mapping or preferences have been defined.

@ZeiP ZeiP force-pushed the sms_sender_preference branch 5 times, most recently from 7b9bc3c to 20271f1 Compare February 22, 2022 20:51
@ZeiP
Fix code style issues and the sender map logic to handle the empty pr…
f395ee1 
…ef case correctly.

Also fixed the rails script to use the correct directory always.
@ZeiP ZeiP force-pushed the sms_sender_preference branch from 20271f1 to f395ee1 Compare February 22, 2022 20:52
@ZeiP ZeiP force-pushed the sms_sender_preference branch from 33b3fe4 to 987f284 Compare February 23, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ZeiP