Bump version to 3.0.0

Tradias · Feb 14, 2024 · bfc59cd · bfc59cd
1 parent 222a018
commit bfc59cd
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -26,7 +26,7 @@ endif()
 
 project(
     asio-grpc
-    VERSION 2.9.3
+    VERSION 3.0.0
     DESCRIPTION "Asynchronous gRPC with Asio/unified executors"
     HOMEPAGE_URL "https://github.com/Tradias/asio-grpc"
     LANGUAGES CXX)

diff --git a/cmake/AsioGrpcProtobufGenerator.cmake b/cmake/AsioGrpcProtobufGenerator.cmake
@@ -19,7 +19,7 @@ In the same directory that called `find_package(asio-grpc)` the following CMake
 It can be used to generate Protobuf/gRPC source files from `.proto` schemas.<br>
 
 If you are using [cmake-format](https://github.com/cheshirekow/cmake_format) then you can copy the `asio_grpc_protobuf_generate` section from
-[cmake-format.yaml](https://github.com/Tradias/asio-grpc/blob/v2.9.3/cmake-format.yaml#L2-L14) to get proper formatting.
+[cmake-format.yaml](https://github.com/Tradias/asio-grpc/blob/v3.0.0/cmake-format.yaml#L2-L14) to get proper formatting.
 
 ```cmake
 asio_grpc_protobuf_generate(PROTOS <proto_file1> [<proto_file2>...]

diff --git a/sonar-project.properties b/sonar-project.properties
@@ -5,7 +5,7 @@ sonar.host.url=https://sonarcloud.io
 
 # This is the name and version displayed in the SonarCloud UI.
 sonar.projectName=asio-grpc
-sonar.projectVersion=2.9.3
+sonar.projectVersion=3.0.0
 
 # Path is relative to the sonar-project.properties file. Replace "\" by "/" on Windows.
 sonar.sources=src

diff --git a/src/agrpc/health_check_service.hpp b/src/agrpc/health_check_service.hpp
@@ -99,7 +99,7 @@ class HealthCheckService final : public grpc::HealthCheckServiceInterface
  * @brief Add a HealthCheckService to a `grpc::Server`
  *
  * Must be called before `grpc::ServerBuilder.BuildAndStart()` and the service must be started using
- * `agrpc::start_health_check_service` after BuildAndStart. May only be called once for a given ServerBuilder.
+ * `agrpc::start_health_check_service` afterwards. May only be called once for a given ServerBuilder.
  *
  * Example:
  *
@@ -114,8 +114,8 @@ grpc::ServerBuilder& add_health_check_service(grpc::ServerBuilder& builder);
 /**
  * @brief Start a previously added HealthCheckService
  *
- * Must be called before `grpc::ServerBuilder.BuildAndStart()` and the service must be started using
- * `agrpc::start_health_check_service` after BuildAndStart. May only be called once for a given ServerBuilder.
+ * Must be called after `grpc::ServerBuilder.BuildAndStart(). The service must have been added using
+ * `agrpc::add_health_check_service()`. May only be called once for a given HealthCheckService.
  *
  * Does not contribute to the work tracking of the GrpcContext. May not be called concurrently with
  * `GrpcContext::run/poll`.

diff --git a/test/src/test_server_rpc_20.cpp b/test/src/test_server_rpc_20.cpp
@@ -337,7 +337,7 @@ TEST_CASE_TEMPLATE("Awaitable ServerRPC/ClientRPC server streaming no finish cau
         {
             auto rpc = test.create_rpc();
             test.start_rpc(rpc, request, response, yield);
-            CHECK(rpc.read(response, yield));
+            rpc.read(response, yield);
             CHECK_EQ(grpc::StatusCode::CANCELLED, rpc.finish(yield).error_code());
         });
 }