You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just looked into hassle_rs::compile_hlsl and I saw that the compiler is recreated every time the function is called. I though about using a thread local to store the DxcLibrary and DxcCompiler and just take the compiler for the current thread (as Dxc is not thread safe). Just had the idea and wanted to ask what your thoughts are on it.
This is more of a discussion than an issue, but I'm posting it here because I can't create a discussion :)
If you agree with me on the idea, I can of course make a pull request!
The text was updated successfully, but these errors were encountered:
I also want this function to be gone, and instead improve the error reporting in Dxc::compile() directly at which point the helper function hardly provides any extra functionality over just constructing Dxc with a default constructor and calling .compile() on it directly. I've worked on this on and off, there's an error/errors branch around that I'll try to revive and finish.
I just looked into
hassle_rs::compile_hlsl
and I saw that the compiler is recreated every time the function is called. I though about using a thread local to store theDxcLibrary
andDxcCompiler
and just take the compiler for the current thread (as Dxc is not thread safe). Just had the idea and wanted to ask what your thoughts are on it.This is more of a discussion than an issue, but I'm posting it here because I can't create a discussion :)
If you agree with me on the idea, I can of course make a pull request!
The text was updated successfully, but these errors were encountered: