Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoring algorithm #263

Open
michelemottini opened this issue Sep 24, 2011 · 1 comment
Open

Scoring algorithm #263

michelemottini opened this issue Sep 24, 2011 · 1 comment

Comments

@michelemottini
Copy link

The scoring algorithm assign a CONTAINER_AREA_BONUS to figures based on their minH - the idea seems to be that bigger figures (usually pictures) are more important and so should go first. Am I right?

If this is the case why use minH and not the area (something like Math.sqrt(mapped_container.figureSize.minH * mapped_container.figureSize.minW)? Using only the height privileges vertical pictures.

Wouldn't be better to have a bonus based on the position of the figures in the article instead of the size? Presumably whoever is creating the content knows what is more imporant and could place it at the beginning of the article.

Thanks

@andreacampi
Copy link
Member

In my local builds I use the area, the square root is probably a better idea (same order of magnitude as one side).

I don't really see a real disadvantage to this change; depending on the content, it will change the "best grid" for someone, but that's a given.
I will clean it up and send a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants