-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some other custom nodes being incompatible #25
Comments
What? This sound weird. I don't think this is related to 0246 but more Manager specifically. I think you should better try to test by installing other modules first before checking if it's the problem related to 0246. Meanwhile you could try to open issue over at https://github.com/ltdrdata/ComfyUI-Manager Feels free to reopen if there's confirmation from |
I know this seems weird but I ran into this today on my Linux system as well. The other symptom I see is that when I load a workflow, all of the nodes in the workflow are red and I get an error popup telling me the nodes can't be found. |
Hm looks like I forgot to check on ComfyUI latest version. Will probably check when I have free time. |
Also @drwootton @thinker88 can you guys post log? Just copy paste what comfy dumped in the terminal to here or upload the log file. Also can you guys confirm by starting ComfyUI from scratch without any plugins then exclusively add 0246 back to see if it break. |
Here is my loading log (module ComfyUI-0246 loaded) -- Manager not appearing
|
And here is the log without the module ComfyUI-0246 loaded and the Manager working again:
|
I did test it with a fresh version and it works fine, my guess is that I have other custom nodes that are not happy when installing yours |
Here are my logs, with and without the ComfyUI_0246 extension installed. |
@drwootton can you confirm fresh version of ComfyUI without any plugins then add back 0246 and Manager and see if that works on your side. |
For @thinker88 can you do something like this? Before starting comfy server, open a stub page like http://example.com. Then open the JS console by pressing Ctrl+shift+i. Then start comfy. When a new tab opened, copy the address, then close that one. Then just go to the stub tab then paste the comfy GUI address in. Wait for a couple minutes. Then can you copy and post the console log here? I'm suspecting it's something to do with client side. |
I did the following
I don't know what's going on here, but in my complete ComfyUI install the presence or absence of the ComfyUI-0246 extension breaks ComfyUI as noted above with no manager, and all workflow nodes colored red. I also don't know Python that well or how ComfyUI works, but from my experience as a C programmer, a recent (within a week or two) commit either has function, variable or class name that collides with something else in a global namespace, or a recent commit registered something to a ComfyUI service that it didn't before and that clobbered something. An remote possibility is that this is somehow order dependent in the way the custom_nodes directory is searched to find extensions is affected by the order of what extension thye search finds first |
Hm looks like on both cases some other custom nodes are in conflict with 0246. I'll probably try to find which common custom nodes cause it. |
Attempted to check similar custom nodes installed on both cases, these appeared:
So I guess that boil down the conflict a bit. |
Removing ComfyUI-Easy-Use (https://github.com/yolain/ComfyUI-Easy-Use), Manager and ComfyUI-0246 seems to work fine together |
I recently installed this custom node, after restarting. Comfyui doesn't load the manager. After removing the module the manager comes back.
The text was updated successfully, but these errors were encountered: