Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Stacks ecosystem prettier config #1

Open
kyranjamie opened this issue May 31, 2022 · 2 comments
Open

Use Stacks ecosystem prettier config #1

kyranjamie opened this issue May 31, 2022 · 2 comments

Comments

@kyranjamie
Copy link
Collaborator

kyranjamie commented May 31, 2022

It'd be great if code could follow consistent formatting with the rest of Stack ecosystem code.

The config is shared as a npm package here https://www.npmjs.com/package/@stacks/prettier-config

@dakai-bot
Copy link
Contributor

The following commit message should fix this issue: 92e50b1

@kyranjamie
Copy link
Collaborator Author

kyranjamie commented Jul 4, 2022

I see that @stacks/prettier-config has been added as a package, but it hasn't been configured.

It can be set by adding this line to the package.json, otherwise editors don't know which config to use.

"prettier": "@stacks/prettier-config",

Further, it can be a devDependency, not a dependency.

We have this command ran as a github action to ensure that all code is formatted consistently

 "lint:prettier": "prettier --check \"{src,tests}/**/*.{ts,tsx}\" \"*.{js,json}\"",

@kyranjamie kyranjamie reopened this Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants