Fixed package.json lint script #533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs/closes #532 - The lint script was failing due to issues with parsing JS files - it should be passing on the main branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs/closes #532
Others encountering this issue have resolved the problem by migrating from
babel-eslint(deprecated as of March 2020) to@babel/eslint-parser.babel-eslintto@babel/eslint-parser.lint-fixscript was added to package.json for future convenience.prop-typesand an inline eslint disableyarn run lintnow passes but it wasn't clear if the eslint rules were configured as desired. There's obviously lots of automated fixes in this PR that could possibly be resolved by changing the config rather than changing the code. I'm happy to change the eslint rules to whatever the project maintainers prefer and update this PR accordingly.