Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database.backup() typings? #1655

Open
benallfree opened this issue Nov 10, 2022 · 6 comments · May be fixed by #1726
Open

Database.backup() typings? #1655

benallfree opened this issue Nov 10, 2022 · 6 comments · May be fixed by #1726
Labels
feature request pr wanted

Comments

@benallfree
Copy link

Summary

Hi, I noticed there are no TS typings for Database.backup and the Backup class.

Would you like a PR for that?

https://github.com/TryGhost/node-sqlite3/blob/master/src/backup.h#L17

Proposed implementation

Add typings and wiki docs for https://github.com/TryGhost/node-sqlite3/blob/master/src/backup.h#L17
@daniellockyer
Copy link
Member

A PR for this would be great 🙂

benallfree added a commit to benallfree/node-sqlite3 that referenced this issue Nov 11, 2022
@benallfree
TryGhost#1655 Database.backup() typings
b5bd593
@benallfree benallfree mentioned this issue Nov 11, 2022
Closed
@ethyaan
Copy link

ethyaan commented Oct 31, 2023

one year later, no changes on this this yet.

@benallfree benallfree linked a pull request Oct 31, 2023 that will close this issue
Open
@benallfree
Copy link
Author

@ethyaan Thanks for reminding me, I just made a PR for this.

@benallfree
Copy link
Author

@daniellockyer Check it out please :)

@ethyaan
Copy link

ethyaan commented Oct 31, 2023

@benallfree Thank you, and btw any hands required? just let me know.

@viniciusteixeiradias
Copy link

Why is this still open?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request pr wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Database.backup() typings pockethost/node-sqlite3
4 participants
@daniellockyer @benallfree @ethyaan @viniciusteixeiradias