Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action count to commit message - Extend current commit message to not only list new/updated/removed services/actions #1

Open
TryTryAgain opened this issue Jan 17, 2024 · 0 comments

Comments

@TryTryAgain
Copy link
Owner

As suggested glassechidna/trackiam#7 ... to make the commit message more useful at a glance.

So, for example, the message from:

"New Services: 'networkmonitor'. Added actions to 'codecommit,networkmonitor,sagemaker'."

Would become something like:
"New Services: 'networkmonitor'. Added 1 action for 'codecommit', 12 actions for 'networkmonitor', and 1 action for 'sagemaker'."

That issue from trackiam reminded me I've wanted to extend the readability/usefulness of the aws-iam-actions-list commit messages. I've wondered if it should even go as far as including all actions but that seems excessive (it is in the git commit/diff one click away after all). Either way, I think adding the count (total actions, added/removed, for that service) is a great idea...and I'll look to add that going forward. I wouldn't want to break people's forks but I would be willing to force change old commit messages to include that information retroactively too...not sure how that would work or if people would oppose it; that is what I did when I hard-forked the project that inspired this one to go from generic commit messages like "added actions" just like trackiam is currently doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant