Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Translation #234

Open
ghost opened this issue Sep 27, 2018 · 7 comments
Open

Missing Translation #234

ghost opened this issue Sep 27, 2018 · 7 comments

Comments

@ghost
Copy link

ghost commented Sep 27, 2018

I get a missing translation in all my templates. Completion works but the preview of translated string not.

bildschirmfoto 2018-09-27 um 12 22 32

@Turbo87
Copy link
Owner

Turbo87 commented Sep 27, 2018

can you reproduce this in a fresh new ember app?

@ghost
Copy link
Author

ghost commented Sep 27, 2018

@Turbo87 , I’ll do it next week when I’m back at office

@ghost
Copy link
Author

ghost commented Sep 27, 2018

Before I forget I use ember-intl

@makepanic
Copy link
Contributor

It could be caused by new ember-intl configs not using baseLocale anymore.
The ember-intl code searches for its value https://github.com/Turbo87/intellij-emberjs/blob/master/src/main/kotlin/com/emberjs/translations/EmberIntlBaseLocaleFinder.kt#L12

With falling back through baseLocale, en-us and en it won't find the correct translation if the project uses a new ember-intl version wihtout having en-us or en translations in place.

@onceatime can you provide us with more information, i.e. ember-intl version and your ember-intl configuration?

If this is really the cause, I could open a PR to fallback through all configured intl locales if that's ok.

@ghost
Copy link
Author

ghost commented Oct 1, 2018

Im knocked out this week. I’ll try to test it ASAP.ä when I’m back on track. But the configuration fallback sounds cool. The best solution or maybe as a separate module or feature could be a dialogue where the user can choose what translations should be used.

@ghost
Copy link
Author

ghost commented Oct 2, 2018

@makepanic my configuration is the default which comes with ember-intl (no changes).

emmber-intl version: 3.2.5

@vaxul
Copy link

vaxul commented Dec 9, 2024

it won't find the correct translation if the project uses a new ember-intl version wihtout having en-us or en translations in place.

@makepanic Hello 🙂 I stumbled over this issue. Wouldn't it a solution to read the default or fallback language if ember-intl? Or alternatively allow to set the key within the IDE plugin settings?

In my case the default language is 'de-de' and there is no translation to English.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants