Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript files like component.ts are not recognized as components in hbs templates #243

Open
janmisek opened this issue Nov 26, 2018 · 3 comments

Comments

@janmisek
Copy link

janmisek commented Nov 26, 2018

Description

Typescript files like component.ts are not recognized as components in hbs templates. Based on standard typescript usage regarding ember-cli-typescript

Steps to Reproduce

Create component.ts file in any component namespace. component.ts use standard component definition:

import Component from "@ember/component";
export default class PropListComponent extends Component {}

Expected behavior:

Autocompletion in any hbs template will offer the component for autocompletion.

Actual behavior:

Go to any template and try component autocompletion ctrl+space, component is not there.

Reproduces how often:

Versions

Always

Additional Information

none

@janmisek
Copy link
Author

Actually its only thing which blocks me from using typescript on component layer in our projects as we have large components base which is not very usable without autocompletion. Does this require big change ? if not I can try to prepare pr myself. But I have not written any intellij plugin yet so could you point me to test of this component.js behaviour. I can start from there.

@Turbo87
Copy link
Owner

Turbo87 commented Nov 26, 2018

Does this require big change ? if not I can try to prepare pr myself.

I think the necessary change should be quite small, but unforunately I'm not entirely sure where it needs to be done either. If I remember correct this behavior is defined in one of the ReferenceContributor classes.

@janmisek
Copy link
Author

Thanks. This is just enough hint. I will take a look soon.

@patricklx patricklx mentioned this issue Nov 21, 2020
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants