Skip to content

Commit 9e946c0

Browse files
authored
Update design_notes/interface_for_gibbs.md
1 parent 5127bc8 commit 9e946c0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

design_notes/interface_for_gibbs.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ For situations where model-specific details are required to compute the log dens
6666

6767
### Regarding `AbstractPPL.condition`
6868

69-
While the `condition` function is a promising idea for Gibbs sampling, it is not currently being utilized in _Turing.jl_'s implementation. Instead, _Turing.jl_ uses a `GibbsContext` for reasons outlined [here](https://github.com/TuringLang/Turing.jl/blob/3c91eec43176d26048b810aae0f6f2fac0686cfa/src/experimental/gibbs.jl#L1-L12). Additionally, _JuliaBUGS_ requires caching the Markov blanket when calling `condition`, which means the proposed `Gibbs` implementation in this PR would not be fully compatible.
69+
While the `condition` function is a promising idea for Gibbs sampling, it is not currently being utilized in _Turing.jl_'s implementation. Instead, _Turing.jl_ uses a `GibbsContext` for reasons outlined [here](https://github.com/TuringLang/Turing.jl/blob/3c91eec43176d26048b810aae0f6f2fac0686cfa/src/experimental/gibbs.jl#L1-L12). Additionally, _JuliaBUGS_ requires caching the Markov blanket when calling `condition`, which means the proposed `Gibbs` implementation in the PR above would not be fully compatible.
7070

7171
### Samplers Should Not Manage Variable Names
7272

0 commit comments

Comments
 (0)