Use twoπ and convert it
#258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
reviewed
Sep 24, 2023
There was a problem hiding this comment.
Thank you for the PR!
Two suggestions:
- Can you remove the Tau dependency and just use
twoπwhich is already available via StatsFuns (and IrrationalConstants)? - Can you remove the
eltypedefinitions? They are not supposed to denote the parameter types and likely to be changed/clarified in Distributions, sp it's safer to not implememt them for now (and they are not needed for the fix)?
|
I used |
devmotion
reviewed
Sep 24, 2023
| end | ||
|
|
||
| function Distributions._logpdf(d::TuringDiagMvNormal, x::AbstractVector) | ||
| return -(length(x) * log(2π) + 2 * sum(log.(d.σ)) + sum(abs2.((x .- d.m) ./ d.σ))) / 2 | ||
| s = sum(log, d.σ) |
There was a problem hiding this comment.
sum(log....) to sum(log, ...)) which in the past caused sometimes problems with AD. Better not include such changes.
|
Closed in favour of #259 to avoid unrelated changes. |
|
Thank you for the PR but I think it's better to keep it as minimal as possible 🙂 |
|
OK, thanks for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156