Skip to content

Commit 1d211c5

Browse files
committed
removed vars field from PriorContext and LikelihoodContext as
it's no longer used functionality (was dropped when we dropped the logprob-macro)
1 parent 7488238 commit 1d211c5

File tree

2 files changed

+8
-122
lines changed

2 files changed

+8
-122
lines changed

src/context_implementations.jl

-101
Original file line numberDiff line numberDiff line change
@@ -77,44 +77,6 @@ function tilde_assume(
7777
return tilde_assume(rng, childcontext(context), args...)
7878
end
7979

80-
function tilde_assume(context::PriorContext{<:NamedTuple}, right, vn, vi)
81-
if haskey(context.vars, getsym(vn))
82-
vi = setindex!!(vi, tovec(get(context.vars, vn)), vn)
83-
settrans!!(vi, false, vn)
84-
end
85-
return tilde_assume(PriorContext(), right, vn, vi)
86-
end
87-
function tilde_assume(
88-
rng::Random.AbstractRNG, context::PriorContext{<:NamedTuple}, sampler, right, vn, vi
89-
)
90-
if haskey(context.vars, getsym(vn))
91-
vi = setindex!!(vi, tovec(get(context.vars, vn)), vn)
92-
settrans!!(vi, false, vn)
93-
end
94-
return tilde_assume(rng, PriorContext(), sampler, right, vn, vi)
95-
end
96-
97-
function tilde_assume(context::LikelihoodContext{<:NamedTuple}, right, vn, vi)
98-
if haskey(context.vars, getsym(vn))
99-
vi = setindex!!(vi, tovec(get(context.vars, vn)), vn)
100-
settrans!!(vi, false, vn)
101-
end
102-
return tilde_assume(LikelihoodContext(), right, vn, vi)
103-
end
104-
function tilde_assume(
105-
rng::Random.AbstractRNG,
106-
context::LikelihoodContext{<:NamedTuple},
107-
sampler,
108-
right,
109-
vn,
110-
vi,
111-
)
112-
if haskey(context.vars, getsym(vn))
113-
vi = setindex!!(vi, tovec(get(context.vars, vn)), vn)
114-
settrans!!(vi, false, vn)
115-
end
116-
return tilde_assume(rng, LikelihoodContext(), sampler, right, vn, vi)
117-
end
11880
function tilde_assume(::LikelihoodContext, right, vn, vi)
11981
return assume(NoDist(right), vn, vi)
12082
end
@@ -328,37 +290,6 @@ function dot_tilde_assume(
328290
end
329291

330292
# `LikelihoodContext`
331-
function dot_tilde_assume(context::LikelihoodContext{<:NamedTuple}, right, left, vn, vi)
332-
return if haskey(context.vars, getsym(vn))
333-
var = get(context.vars, vn)
334-
_right, _left, _vns = unwrap_right_left_vns(right, var, vn)
335-
set_val!(vi, _vns, _right, _left)
336-
settrans!!.((vi,), false, _vns)
337-
dot_tilde_assume(LikelihoodContext(), _right, _left, _vns, vi)
338-
else
339-
dot_tilde_assume(LikelihoodContext(), right, left, vn, vi)
340-
end
341-
end
342-
function dot_tilde_assume(
343-
rng::Random.AbstractRNG,
344-
context::LikelihoodContext{<:NamedTuple},
345-
sampler,
346-
right,
347-
left,
348-
vn,
349-
vi,
350-
)
351-
return if haskey(context.vars, getsym(vn))
352-
var = get(context.vars, vn)
353-
_right, _left, _vns = unwrap_right_left_vns(right, var, vn)
354-
set_val!(vi, _vns, _right, _left)
355-
settrans!!.((vi,), false, _vns)
356-
dot_tilde_assume(rng, LikelihoodContext(), sampler, _right, _left, _vns, vi)
357-
else
358-
dot_tilde_assume(rng, LikelihoodContext(), sampler, right, left, vn, vi)
359-
end
360-
end
361-
362293
function dot_tilde_assume(context::LikelihoodContext, right, left, vn, vi)
363294
return dot_assume(nodist(right), left, vn, vi)
364295
end
@@ -368,38 +299,6 @@ function dot_tilde_assume(
368299
return dot_assume(rng, sampler, nodist(right), vn, left, vi)
369300
end
370301

371-
# `PriorContext`
372-
function dot_tilde_assume(context::PriorContext{<:NamedTuple}, right, left, vn, vi)
373-
return if haskey(context.vars, getsym(vn))
374-
var = get(context.vars, vn)
375-
_right, _left, _vns = unwrap_right_left_vns(right, var, vn)
376-
set_val!(vi, _vns, _right, _left)
377-
settrans!!.((vi,), false, _vns)
378-
dot_tilde_assume(PriorContext(), _right, _left, _vns, vi)
379-
else
380-
dot_tilde_assume(PriorContext(), right, left, vn, vi)
381-
end
382-
end
383-
function dot_tilde_assume(
384-
rng::Random.AbstractRNG,
385-
context::PriorContext{<:NamedTuple},
386-
sampler,
387-
right,
388-
left,
389-
vn,
390-
vi,
391-
)
392-
return if haskey(context.vars, getsym(vn))
393-
var = get(context.vars, vn)
394-
_right, _left, _vns = unwrap_right_left_vns(right, var, vn)
395-
set_val!(vi, _vns, _right, _left)
396-
settrans!!.((vi,), false, _vns)
397-
dot_tilde_assume(rng, PriorContext(), sampler, _right, _left, _vns, vi)
398-
else
399-
dot_tilde_assume(rng, PriorContext(), sampler, right, left, vn, vi)
400-
end
401-
end
402-
403302
# `PrefixContext`
404303
function dot_tilde_assume(context::PrefixContext, right, left, vn, vi)
405304
return dot_tilde_assume(context.context, right, left, prefix.(Ref(context), vn), vi)

src/contexts.jl

+8-21
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ DefaultContext()
5353
julia> ctx_prior = DynamicPPL.setchildcontext(ctx, PriorContext()); # only compute the logprior
5454
5555
julia> DynamicPPL.childcontext(ctx_prior)
56-
PriorContext{Nothing}(nothing)
56+
PriorContext()
5757
```
5858
"""
5959
setchildcontext
@@ -97,7 +97,7 @@ ParentContext(ParentContext(DefaultContext()))
9797
9898
julia> # Replace the leaf context with another leaf.
9999
leafcontext(setleafcontext(ctx, PriorContext()))
100-
PriorContext{Nothing}(nothing)
100+
PriorContext()
101101
102102
julia> # Append another parent context.
103103
setleafcontext(ctx, ParentContext(DefaultContext()))
@@ -195,32 +195,19 @@ struct DefaultContext <: AbstractContext end
195195
NodeTrait(context::DefaultContext) = IsLeaf()
196196

197197
"""
198-
struct PriorContext{Tvars} <: AbstractContext
199-
vars::Tvars
200-
end
198+
PriorContext <: AbstractContext
201199
202-
The `PriorContext` enables the computation of the log prior of the parameters `vars` when
203-
running the model.
200+
A leaf context resulting in the exclusion of likelihood terms when running the model.
204201
"""
205-
struct PriorContext{Tvars} <: AbstractContext
206-
vars::Tvars
207-
end
208-
PriorContext() = PriorContext(nothing)
202+
struct PriorContext <: AbstractContext end
209203
NodeTrait(context::PriorContext) = IsLeaf()
210204

211205
"""
212-
struct LikelihoodContext{Tvars} <: AbstractContext
213-
vars::Tvars
214-
end
206+
LikelihoodContext <: AbstractContext
215207
216-
The `LikelihoodContext` enables the computation of the log likelihood of the parameters when
217-
running the model. `vars` can be used to evaluate the log likelihood for specific values
218-
of the model's parameters. If `vars` is `nothing`, the parameter values inside the `VarInfo` will be used by default.
208+
A leaf context resulting in the exclusion of prior terms when running the model.
219209
"""
220-
struct LikelihoodContext{Tvars} <: AbstractContext
221-
vars::Tvars
222-
end
223-
LikelihoodContext() = LikelihoodContext(nothing)
210+
struct LikelihoodContext <: AbstractContext end
224211
NodeTrait(context::LikelihoodContext) = IsLeaf()
225212

226213
"""

0 commit comments

Comments
 (0)