From 3b8dceab76ef37d57d0abdecb205a5c46550679f Mon Sep 17 00:00:00 2001 From: Hong Ge <3279477+yebai@users.noreply.github.com> Date: Sat, 10 Aug 2024 12:39:29 +0100 Subject: [PATCH] Fix depreciation for `AutoReverseDiff`. (#638) * Update DynamicPPLReverseDiffExt.jl * Update Project.toml * Update ext/DynamicPPLReverseDiffExt.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update DynamicPPLReverseDiffExt.jl * Update Project.toml --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --- Project.toml | 2 +- ext/DynamicPPLReverseDiffExt.jl | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Project.toml b/Project.toml index d1f486082..e0da1b0c0 100644 --- a/Project.toml +++ b/Project.toml @@ -41,7 +41,7 @@ DynamicPPLReverseDiffExt = ["ReverseDiff"] DynamicPPLZygoteRulesExt = ["ZygoteRules"] [compat] -ADTypes = "0.2, 1" +ADTypes = "1" AbstractMCMC = "5" AbstractPPL = "0.8.4" Accessors = "0.1" diff --git a/ext/DynamicPPLReverseDiffExt.jl b/ext/DynamicPPLReverseDiffExt.jl index b2b378d45..3fd174ed1 100644 --- a/ext/DynamicPPLReverseDiffExt.jl +++ b/ext/DynamicPPLReverseDiffExt.jl @@ -9,12 +9,12 @@ else end function LogDensityProblemsAD.ADgradient( - ad::ADTypes.AutoReverseDiff, ℓ::DynamicPPL.LogDensityFunction -) + ad::ADTypes.AutoReverseDiff{Tcompile}, ℓ::DynamicPPL.LogDensityFunction +) where {Tcompile} return LogDensityProblemsAD.ADgradient( Val(:ReverseDiff), ℓ; - compile=Val(ad.compile), + compile=Val(Tcompile), # `getparams` can return `Vector{Real}`, in which case, `ReverseDiff` will initialize the gradients to Integer 0 # because at https://github.com/JuliaDiff/ReverseDiff.jl/blob/c982cde5494fc166965a9d04691f390d9e3073fd/src/tracked.jl#L473 # `zero(D)` will return 0 when D is Real.