Skip to content

Commit bdf90b4

Browse files
committed
minor fixes
1 parent 1c1c907 commit bdf90b4

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

ext/DynamicPPLMCMCChainsExt.jl

-6
Original file line numberDiff line numberDiff line change
@@ -316,12 +316,6 @@ julia> [first(t.θ.x) for t in transitions] # extract samples for `x`
316316
[-1.704630494695469]
317317
```
318318
"""
319-
function transitions_from_chain(
320-
model::DynamicPPL.Model, chain::MCMCChains.Chains; kwargs...
321-
)
322-
return transitions_from_chain(Random.default_rng(), model, chain; kwargs...)
323-
end
324-
325319
function transitions_from_chain(
326320
rng::DynamicPPL.Random.AbstractRNG,
327321
model::DynamicPPL.Model,

test/ext/DynamicPPLMCMCChainsExt.jl

+5-6
Original file line numberDiff line numberDiff line change
@@ -141,17 +141,16 @@ end
141141
return y ~ MvNormal(mu, error^2 * I)
142142
end
143143

144-
# Some data
145144
x = randn(2, 100)
146145
y = [1 + 2 * a + 3 * b for (a, b) in eachcol(x)]
147146

148147
param_names = Dict(
149-
simple_linear1 => [:intercept, :coef],
150-
simple_linear2 => [:intercept, :coef],
151-
simple_linear3 => [:intercept, Symbol.(["coef[$i]" for i in 1:2])...],
152-
simple_linear4 => [:intercept, :coef1, :coef2],
148+
simple_linear1 => [:intercept, Symbol("coef[1]"), Symbol("coef[2]"), :error],
149+
simple_linear2 => [:intercept, Symbol("coef[1]"), Symbol("coef[2]"), :error],
150+
simple_linear3 => [:intercept, Symbol("coef[1]"), Symbol("coef[2]"), :error],
151+
simple_linear4 => [:intercept, :coef1, :coef2, :error],
153152
)
154-
for model in [simple_linear1, simple_linear2, simple_linear3, simple_linear4]
153+
@testset "$model" for model in [simple_linear1, simple_linear2, simple_linear3, simple_linear4]
155154
m = model(x, y)
156155
chain = sample(
157156
DynamicPPL.LogDensityFunction(m, DynamicPPL.VarInfo(m)),

0 commit comments

Comments
 (0)