Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depreciation for AutoReverseDiff. #638

Merged
merged 6 commits into from
Aug 10, 2024
Merged

Fix depreciation for AutoReverseDiff. #638

merged 6 commits into from
Aug 10, 2024

Conversation

yebai
Copy link
Member

@yebai yebai commented Aug 8, 2024

Fix warnings discovered in TuringLang/Turing.jl#2289

@yebai yebai requested a review from mhauru August 8, 2024 16:57
yebai and others added 2 commits August 8, 2024 17:58
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Aug 8, 2024

Pull Request Test Coverage Report for Build 10330921185

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 30 unchanged lines in 10 files lost coverage.
  • Overall coverage remained the same at 81.36%

Files with Coverage Reduction New Missed Lines %
src/compiler.jl 1 93.42%
ext/DynamicPPLForwardDiffExt.jl 1 83.33%
src/utils.jl 2 78.36%
src/model_utils.jl 2 37.5%
src/context_implementations.jl 2 61.51%
src/varinfo.jl 2 92.52%
src/test_utils.jl 3 85.93%
src/threadsafe.jl 5 48.25%
src/debug_utils.jl 5 53.28%
src/DynamicPPL.jl 7 46.15%
Totals Coverage Status
Change from base Build 10323065547: 0.0%
Covered Lines: 2811
Relevant Lines: 3455

💛 - Coveralls

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.95%. Comparing base (142f753) to head (13561d1).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #638      +/-   ##
==========================================
- Coverage   81.00%   79.95%   -1.05%     
==========================================
  Files          29       29              
  Lines        3470     3468       -2     
==========================================
- Hits         2811     2773      -38     
- Misses        659      695      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I wonder if the dropping of ADTypes v0.2 will create issues with Turing.jl (I recall some broken dependency troubles from earlier), but we'll see that when we run the Turing.jl side of the test suite.

@mhauru mhauru enabled auto-merge August 9, 2024 08:58
@mhauru
Copy link
Member

mhauru commented Aug 9, 2024

The recent tests I added are failing, looking into it.

@yebai yebai disabled auto-merge August 10, 2024 10:25
@yebai yebai enabled auto-merge August 10, 2024 10:26
@yebai yebai added this pull request to the merge queue Aug 10, 2024
Merged via the queue into master with commit 3b8dcea Aug 10, 2024
12 of 14 checks passed
@yebai yebai deleted the yebai-patch-1 branch August 10, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants