-
Notifications
You must be signed in to change notification settings - Fork 37
Allow generation of ParamsWithStats from FastLDF plus parameters, and also bundle_samples
#1129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
penelopeysm
wants to merge
3
commits into
breaking
Choose a base branch
from
py/params-from-ldf
base: breaking
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+183
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Benchmark Report for Commit 2fad97bComputer InformationBenchmark Results |
Closed
Contributor
|
DynamicPPL.jl documentation for PR #1129 is available at: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## breaking #1129 +/- ##
============================================
- Coverage 81.72% 81.53% -0.19%
============================================
Files 42 42
Lines 3928 3953 +25
============================================
+ Hits 3210 3223 +13
- Misses 718 730 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c475f96 to
92cbb20
Compare
92cbb20 to
39df719
Compare
ParamsWithStats from FastLDF plus parametersParamsWithStats from FastLDF plus parameters, and also bundle_samples
3e646ca to
0dd2f70
Compare
0dd2f70 to
077457f
Compare
0150ef4 to
2fad97b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has no real impact on DynamicPPL, but using this in Turing should lead to some nice speedups because this:
unflatten+evaluate!!;Closes #1119.
Since the intention of this is to replace
Turing.Inference.TransitionwithParamsWithStats, I also added the necessaryAbstractMCMC.bundle_samplesmethod here. MCMCChainsExt is the natural place for it to live (it could be defined in Turing, but that would be piracy).