Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Probability Implementation #267

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

naseweisssss
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Jan 14, 2025

Pull Request Test Coverage Report for Build 12766075584

Details

  • 0 of 75 (0.0%) changed or added relevant lines in 1 file are covered.
  • 37 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-2.7%) to 70.707%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/experimental/ProbabilisticGraphicalModels/bayesnet.jl 0 75 0.0%
Files with Coverage Reduction New Missed Lines %
src/experimental/ProbabilisticGraphicalModels/bayesnet.jl 37 0.0%
Totals Coverage Status
Change from base Build 12334000793: -2.7%
Covered Lines: 1441
Relevant Lines: 2038

💛 - Coveralls

@naseweisssss
Copy link
Collaborator Author

This is the non-dp version for implementation, dp version will be addressed in another PR, still thinking of how to write the test for this

@sunxd3
Copy link
Member

sunxd3 commented Jan 15, 2025

First, some high-level stuff. Julia has some conventions on Documentation, sadly, I don't think ChatGPT and Claude understand this yet.

I saw you removed deterministic functions, they do make implementation more difficult, but we can't get rid of them totally if we want to use this for future integration with JuliaBUGS' frontend.

How about try to emulate the implementation here to compute the log density, but adapt it to BayesianNetwork.

Dynamic Programming version is in no hurry, we first get the naive recursion correct, then we worry about make DP work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants