-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring Glue Code #1735
Comments
VarInfo isn't removed, so we still need all VarInfo code, don't we? We rather have to add some SimpleVarInfo code as well if it is added, or preferably generalize the code to AbstractVarInfo. |
Nothing is made unnecessary by the new PR, and so AFAIK there's no glue-code that should be removed. |
It should be refactoring the glue code, I think. We would like to create an interface between Turing-AbstractMCMC that can be shared by more samplers. For example, AdvancedMH and AdvancedHMC can share the log density interface. At the moment there is a lot of redundancy in the glue code which we want to reduce via careful refactoring. |
simplevarinfo
simplevarinfo
So this doesn't have anything to do with I've begun working along these lines here: TuringLang/AbstractMCMC.jl#86. |
simplevarinfo
Closed in favour of #1904 where we will make an effort to reduce redundant glue code by using a cleaner |
Issue for keeping track of the process of removing glue code that is made unnecessary by the new simple varinfo.
The text was updated successfully, but these errors were encountered: