Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring Glue Code #1735

Closed
ParadaCarleton opened this issue Dec 3, 2021 · 6 comments
Closed

Refactoring Glue Code #1735

ParadaCarleton opened this issue Dec 3, 2021 · 6 comments

Comments

@ParadaCarleton
Copy link
Member

Issue for keeping track of the process of removing glue code that is made unnecessary by the new simple varinfo.

@devmotion
Copy link
Member

VarInfo isn't removed, so we still need all VarInfo code, don't we? We rather have to add some SimpleVarInfo code as well if it is added, or preferably generalize the code to AbstractVarInfo.

@torfjelde
Copy link
Member

torfjelde commented Dec 4, 2021

Nothing is made unnecessary by the new PR, and so AFAIK there's no glue-code that should be removed.
We simply have to update some functionality to be compatible with immutable implementations, where most of these can be found in #1726 .

@ParadaCarleton
Copy link
Member Author

@yebai @cpfiffer did I misunderstand what we were talking about yesterday?

@yebai
Copy link
Member

yebai commented Dec 4, 2021

It should be refactoring the glue code, I think. We would like to create an interface between Turing-AbstractMCMC that can be shared by more samplers. For example, AdvancedMH and AdvancedHMC can share the log density interface. At the moment there is a lot of redundancy in the glue code which we want to reduce via careful refactoring.

@ParadaCarleton ParadaCarleton changed the title Removing Glue Code Post-simplevarinfo Refactoring Glue Code Post-simplevarinfo Dec 4, 2021
@torfjelde
Copy link
Member

For example, AdvancedMH and AdvancedHMC can share the log density interface.

So this doesn't have anything to do with SimpleVarInfo, but rather it's related to TuringLang/AbstractMCMC.jl#85, in particular this comment: TuringLang/AbstractMCMC.jl#85 (comment)

I've begun working along these lines here: TuringLang/AbstractMCMC.jl#86.

@ParadaCarleton ParadaCarleton changed the title Refactoring Glue Code Post-simplevarinfo Refactoring Glue Code Dec 4, 2021
@yebai
Copy link
Member

yebai commented Nov 12, 2022

Closed in favour of #1904 where we will make an effort to reduce redundant glue code by using a cleaner VarInfo design from DynamicPPL.

@yebai yebai closed this as completed Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants