-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect output dimensions in stacked bijectors #2066
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #2066 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 22 22
Lines 1488 1492 +4
======================================
- Misses 1488 1492 +4
☔ View full report in Codecov by Sentry. |
It looks good to me. Maybe add the MWE to tests? |
Ok, is the revision in |
I don't think so. You need to bump it manually, too. |
1bb3f8a
to
4d7c810
Compare
Ok so turns out that wasn't the fix, I had to add dispatches for |
I am also running the tests locally so we'll see if these changes break anything. I tried to be specific with the dispatches. |
Pull Request Test Coverage Report for Build 5964052388Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
I don't think this test failure is related to this PR...? but I am not sure from first glance. |
Agreed that it seems not related to this PR |
FWIW the tests passed locally for me. Is anything else needed before merging? |
Thanks, @bgroenks96 -- a random CI failure went away after a second CI run. |
Fixes #2065 (still needs testing)