Add DynamicPPL integration tests#2393
Closed
penelopeysm wants to merge 1 commit intomasterfrom
Closed
Conversation
penelopeysm
commented
Nov 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2393 +/- ##
==========================================
- Coverage 86.41% 86.28% -0.13%
==========================================
Files 22 22
Lines 1575 1575
==========================================
- Hits 1361 1359 -2
- Misses 214 216 +2 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 12171154106Details
💛 - Coveralls |
9f8023c to
1412416
Compare
Member
Author
|
Should be mergeable, I think, then I'll get rid of them from DynamicPPL. |
torfjelde
approved these changes
Nov 28, 2024
Member
torfjelde
left a comment
There was a problem hiding this comment.
Some of these tests could deffo be moved to DynamicPPL.jl proper, but happy to merge them now if accompanied with an issue over at DPPL to ensure we don't loose track of the TODOs:)
1 task
Member
Author
|
Currently thinking it's more prudent to figure out how to move those tests into the DPPL test suite proper 😅 |
ee0e061 to
de0c54c
Compare
Member
Author
|
In line with the above, I'm going to close this PR and open a new one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Turing/DynamicPPL integration tests (from the
test/turingfolder in DynamicPPL) to this repository instead.The main motivation behind this PR is to ensure that the tests added here are always run whenever a new version of Turing is released, thus making it impossible to release a version of Turing that contains a buggy version of DynamicPPL. See TuringLang/DynamicPPL.jl#703 for more thorough explanation.
Some implementation details:
link!(vi, sampler)->link!!(vi, sampler, model); the same withinvlink!; andAutoReverseDiff(false)->AutoReverseDiff(; compile=false)).Otherwise, this is a straight copy paste.