Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement getstepsize() for NoAdaptation samplers #2405

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Nov 29, 2024

Closes #2400

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 44.66%. Comparing base (c0a4ee9) to head (4a78972).

Files with missing lines Patch % Lines
src/mcmc/hmc.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2405      +/-   ##
==========================================
- Coverage   44.72%   44.66%   -0.06%     
==========================================
  Files          22       22              
  Lines        1554     1556       +2     
==========================================
  Hits          695      695              
- Misses        859      861       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@penelopeysm penelopeysm force-pushed the py/getstepsize-noadaptation branch 2 times, most recently from c86a34e to ce5f3a5 Compare November 29, 2024 23:47
@coveralls
Copy link

coveralls commented Nov 29, 2024

Pull Request Test Coverage Report for Build 12110614043

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+6.6%) to 44.666%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/mcmc/hmc.jl 0 2 0.0%
Totals Coverage Status
Change from base Build 12110228665: 6.6%
Covered Lines: 695
Relevant Lines: 1556

💛 - Coveralls

@penelopeysm penelopeysm marked this pull request as ready for review December 1, 2024 19:02
@penelopeysm penelopeysm force-pushed the py/getstepsize-noadaptation branch 2 times, most recently from e39208f to fdcd4d5 Compare December 2, 2024 00:45
@penelopeysm penelopeysm force-pushed the py/getstepsize-noadaptation branch from fdcd4d5 to 4a78972 Compare December 2, 2024 00:46
@penelopeysm penelopeysm requested a review from sunxd3 December 3, 2024 10:53
@sunxd3
Copy link
Member

sunxd3 commented Dec 3, 2024

make sense, but coverage is saying that the added function is not hit, is it making a mistake?

Also a bunch of test errors -- I thought they are not related, but might be?

@penelopeysm
Copy link
Member Author

No idea why the coverage isn't right. I tried to rerun and it's no different...

Yeah the errors are Mooncake related so separate from this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MethodError matching getϵ for AdvancedHMC Adaption
3 participants