Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waterfall plumes "descales" on Revert to Launch! #3

Open
Lisias opened this issue Jan 19, 2022 · 3 comments
Open

Waterfall plumes "descales" on Revert to Launch! #3

Lisias opened this issue Jan 19, 2022 · 3 comments

Comments

@Lisias
Copy link
Contributor

Lisias commented Jan 19, 2022

As the title says.

References:
https://forum.kerbalspaceprogram.com/index.php?/topic/192216-tweakscale-companion-program-2021-1016/&do=findComment&comment=4078509

@Lisias
Copy link
Contributor Author

Lisias commented Jan 26, 2022

I found this issue on the KSP's bug track that may be relevant:

https://bugs.kerbalspaceprogram.com/issues/27484

"Revert to Launch breaks cargo bay aerodynamics"

Cargo containers shield draggy cargo when the craft is initially launched. However, when reverting the flight to the launch site, closed containers behave as if they were open. The only workaround is to revert the flight to the SPH.

@Lisias
Copy link
Contributor Author

Lisias commented Jan 22, 2023

This issue still eludes me.

It's not a life cycle issue, I had confirmed that this problem is happening since Waterfall 0.6.7, the first one I had supported.

So the problem is on my side for sure...

@Lisias
Copy link
Contributor Author

Lisias commented Jan 22, 2023

On a sudden insight, I checked is this is not somewhat similar to TweakScale/TweakScale#246 that I closed recently.

Well, nope. By switching vessels, the WaterfallFX effects are not restored.

You need to switch Scenes (going to Tracking Station and then selecting the same vessel back, etc) in order to restore the Effects.

Internally, TweakScalerWaterfallFX works apparently fine, things are (re)scaled as expected - just checked on debug mode.

What I think it's happening is that WaterfallFX may be rebuilding its effects from scratch, screwing me over when I iterate on the effects to scale them up (because somehow I'm iterating on zombie objects)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant