Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Near Future Launch Vehicles Tanks / Tweakscale RealFuels #7

Open
mikken40 opened this issue Apr 25, 2024 · 3 comments
Open

Near Future Launch Vehicles Tanks / Tweakscale RealFuels #7

mikken40 opened this issue Apr 25, 2024 · 3 comments
Assignees
Labels

Comments

@mikken40
Copy link

Hello,

I use Realism Overhaul and RealFuels.
I have created a patch for the NFLV tanks so that I can also use RealFuels with them. That works great so far.
But the problem is that I can no longer scale these tanks with Tweakscale?
What could be the reason for this? I have already read that RealFuels in conjunction with Tweakscale causes problems for some. And it has been deactivated in the RealFuels settings.
However, I would like to test this myself and cannot find the setting to reactivate Tweakscale for RealFuels.

I thank you in advance for any comment and hope it is described clearly ;)

LG Mike

@Lisias Lisias self-assigned this Apr 25, 2024
@Lisias Lisias transferred this issue from TweakScale/TweakScale Apr 25, 2024
@Lisias
Copy link
Contributor

Lisias commented Apr 25, 2024

Transferring the issue to the proper place.

TweakScale (the main distribution) only supports Stock and DLCs, anything else is handled by a Companion.

The Companion that will handle Real Fuels is this one.

@Lisias
Copy link
Contributor

Lisias commented Apr 25, 2024

@mikken40 , exactly what do you mean to "been deactivated"?

The part lost the scaling capability, or it is not being scaled correctly?

@Lisias
Copy link
Contributor

Lisias commented May 31, 2024

Now I understand. 0n TweakScale/TweakScale#326 the user explained that it can't scale the part after adding support for Real Fuels.

TL;DR: Real Fuel support is in need to be tested.

The Companions were kinda stalled since I got screwed by TweakScale/TweakScale#307 - there's no point into adding support for 3rd parties when I was unable to correctly understand scaling Stock.

Since TweakScale/TweakScale#307 is now under control (the PartModule is being instantiated with enable = true when it used to be false since 1.9.0), it's now plausible to go back to implementing the Companions.

I will check this issue this WeekEnd - RealFuels, in theory should be working.

@Lisias Lisias added the support label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants