Merge pull request #73 from TwilioDevEd/update-configuration-files

Update configuration files

Author: jefflinwood

.env.example

@@ -1,3 +1,4 @@
 TWILIO_ACCOUNT_SID=ACxxxxxxxxxxxxx
 TWILIO_AUTH_TOKEN=Your-Twilio-Auth-Token
 TWILIO_NUMBER=+1707XXXXXXX
+NODE_ENV=production

app.js

@@ -29,4 +29,17 @@ app.use((req, res, next) => {
 
 app.use('/', MessagingRouter());
 
+/**
+ * production error handler
+ * no stacktraces leaked to user
+ */
+// eslint-disable-next-line no-unused-vars
+app.use((err, req, res, next) => {
+  res.status(err.status || 500);
+  res.send({
+    message: err.message,
+    error: {},
+  });
+});
+
 module.exports = app;

package.json

@@ -2,10 +2,9 @@
   "name": "receive-mms-node",
   "version": "1.0.0",
   "scripts": {
-    "install": "npm run lint && npm test",
     "lint": "node_modules/.bin/eslint ./",
     "start": "node index.js",
-    "test": "NODE_ENV=test node_modules/.bin/mocha test test/**/*.spec.js"
+    "test": "NODE_ENV=test node_modules/.bin/mocha test test/**/*.spec.js && yarn run lint"
   },
   "description": "How to receive MMS messages with node.js",
   "author": {
@@ -45,7 +44,7 @@
   "devDependencies": {
     "chai": "^4.0.2",
     "cheerio": "^1.0.0-rc.1",
-    "eslint": "^3.19.0",
+    "eslint": "^8.1.0",
     "eslint-config-airbnb": "^15.0.1",
     "eslint-plugin-import": "^2.3.0",
     "eslint-plugin-jsx-a11y": "^5.0.3",

routes/messaging.js

@@ -27,10 +27,11 @@ function MessagingRouter() {
   function deleteMediaItem(mediaItem) {
     const client = getTwilioClient();
 
-    return client
-      .api.accounts(twilioAccountSid)
+    return client.api
+      .accounts(twilioAccountSid)
       .messages(mediaItem.MessageSid)
-      .media(mediaItem.mediaSid).remove();
+      .media(mediaItem.mediaSid)
+      .remove();
   }
 
   async function SaveMedia(mediaItem) {
@@ -51,14 +52,14 @@ function MessagingRouter() {
     }
   }
 
-
   async function handleIncomingSMS(req, res) {
     const { body } = req;
     const { NumMedia, From: SenderNumber, MessageSid } = body;
     let saveOperations = [];
     const mediaItems = [];
 
-    for (var i = 0; i < NumMedia; i++) {  // eslint-disable-line
+    for (let i = 0; i < NumMedia; i += 1) {
+      // eslint-disable-line
       const mediaUrl = body[`MediaUrl${i}`];
       const contentType = body[`MediaContentType${i}`];
       const extension = extName.mime(contentType)[0].ext;
@@ -71,20 +72,23 @@ function MessagingRouter() {
 
     await Promise.all(saveOperations);
 
-    const messageBody = NumMedia === 0 ?
-    'Send us an image!' :
-    `Thanks for sending us ${NumMedia} file(s)`;
+    const messageBody =
+      NumMedia === 0
+        ? 'Send us an image!'
+        : `Thanks for sending us ${NumMedia} file(s)`;
 
     const response = new MessagingResponse();
-    response.message({
-      from: twilioPhoneNumber,
-      to: SenderNumber,
-    }, messageBody);
+    response.message(
+      {
+        from: twilioPhoneNumber,
+        to: SenderNumber,
+      },
+      messageBody,
+    );
 
     return res.send(response.toString()).status(200);
   }
 
-
   function getRecentImages() {
     return images;
   }

send-mms.js

@@ -4,10 +4,11 @@ const Twilio = require('twilio');
 const { twilioAccountSid, twilioAuthToken, twilioPhoneNumber } = config;
 const client = new Twilio(twilioAccountSid, twilioAuthToken);
 
-client.messages.create({
-  to: twilioPhoneNumber,
-  from: twilioPhoneNumber,
-  body: 'This is the ship that made the Kessel Run in fourteen parsecs?',
-  mediaUrl: 'https://c1.staticflickr.com/3/2899/14341091933_1e92e62d12_b.jpg',
-})
-.done();
+client.messages
+  .create({
+    to: twilioPhoneNumber,
+    from: twilioPhoneNumber,
+    body: 'This is the ship that made the Kessel Run in fourteen parsecs?',
+    mediaUrl: 'https://c1.staticflickr.com/3/2899/14341091933_1e92e62d12_b.jpg',
+  })
+  .done();

test/messaging.spec.js

@@ -38,7 +38,7 @@ describe('appointment', () => {
   beforeEach(() => {
     TwilioMock.twiml = Twilio.twiml;
     mockery.registerMock('twilio', TwilioMock);
-    const app = require('../app');  // eslint-disable-line global-require
+    const app = require('../app');// eslint-disable-line global-require
     agent = supertest(app);
   });