-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate emoji picker #808
Comments
/bounty 100 |
💎 $100 bounty • BlockNoteSteps to solve:
Thank you for contributing to TypeCellOS/BlockNote! Add a bounty • Share on socials
|
Please assign @YousefED |
/attempt
|
/attempt #808 Edit: and i am creating a new file in packages/core/src/extensions/SuggestionMenu named getDefaultEmojiMenuItems.ts where i will get the emojis from the emoji-mart return them. ps: can i get assigned.
|
I implemented it and then suddenly got a better idea on how to do it so it wil take some more time. |
/attempt #808
|
@syedbarimanjan any update on this? Otherwise I'll assign another attempt later this week |
I am working on it, trying to integrate emoji-mart picker as it has all the functionality we need. If that is not possible then i will have to create the picker myself which means alot of more code to maintain. |
Alright, thanks for the update! |
@hunxjunedo if you have a working fix create a pr till tonight. |
@YousefED I'm going with that, you okay with this ? Coming back in abt 12 hours. |
I will restart working on it at night so if you already have a working solution you can raise a pr. |
@YousefED I've implemented it and prepared to raise the pull request. Should I proceed or wait till I get assigned ? Screencast.from.19-06-2024.20.11.04.webm |
If you have it ready you can raise a pr as syed suggests. Then ill review
that tomorrow or friday and decide how to move fwd
…On Wed, 19 Jun 2024 at 17:48, Hunain Ahmed ***@***.***> wrote:
@YousefED <https://github.com/YousefED> I've implemented it and prepared
to raise the pull request. Should I proceed or wait till I get assigned ?
—
Reply to this email directly, view it on GitHub
<#808 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAC2BWOV5ALHMX5NZKEJT5DZIGR6NAVCNFSM6AAAAABI2KJG7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGAYTSNRQGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Alright, doing it as soon as I get to a computer. |
💡 @hunxjunedo submitted a pull request that claims the bounty. You can visit your bounty board to reward. |
@YousefED I've raised a PR, kindly review it. |
Hey @YousefED is this still open? |
🎉🎈 @hunxjunedo has been awarded $100! 🎈🎊 |
Describe the solution you'd like
An emoji picker that works similar to the one in Notion:
Main requirements:
[ ] Easy to update with new emojis, possibly use a library like https://www.npmjs.com/package/emoji-mart, https://www.npmjs.com/package/react-input-emoji, or different
[ ] As seen in the gif above, the focus should remain on the editor, while the user filters. Perhaps it needs to be implemented as a custom suggestion menu, but that currently doesn't have support for keyboard nav to left / right, so that would need to be added. It might be necessary to create your own version of
SuggestionMenuController
for this (and share common code nicely)[ ] Should be accessible (both keyboard navigation and screen reader support would be ideal)
[ ] Component should be selectable both via the slash menu, and when the user types a trigger character (
:
)This will require to get up to speed with the codebase and understand how suggestions work internally, so I don't recommend this issue for beginners
The text was updated successfully, but these errors were encountered: