Add control message expiration time #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taesungh
approved these changes
Jun 1, 2024
Comment on lines
+88
to
+90
| // Calculate time difference in microseconds and check if the difference is | ||
| // greater than the expiration time. If so, set frequency to 0. Otherwise, | ||
| // set frequency to the data received. |
There was a problem hiding this comment.
Nitpick [non-blocking]: comment seems a bit too verbose, describing the code literally rather than explaining intent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #37.
Changes
absolute_time_diff_usfrompico/time.hto calculate difference between last received message and the current timeEXPIRATION_TIME, set the frequency to be zeromonitor_serialto directly assign tolcmrather than assigning by attribute