Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape reveals all variables in PB on the web version #35

Open
rlisahuang opened this issue Mar 2, 2023 · 1 comment
Open

Escape reveals all variables in PB on the web version #35

rlisahuang opened this issue Mar 2, 2023 · 1 comment
Labels
PB tmpfix web

Comments

@rlisahuang
Copy link

Suspect: race condition with some action also handled by Escape in RTV
@rlisahuang rlisahuang added bug Something isn't working LEAP Anything specifically about LEAP. web urgent labels Mar 2, 2023
@rlisahuang rlisahuang self-assigned this Mar 2, 2023
@rlisahuang
Copy link
Author

The source of the problem is that in the web version, ViewMode is still set to Full despite that ModVars is set to true by default, while in the local version ViewMode is set to Custom. This discrepancy causes pressing Escape in the web version to accidentally bring out all variables in PB instead of cancelling the code suggestion insertion.

More investigation is needed to fully resolve this issue. For now I did a simple hack -- tell PB that "leap is on" when Leap is constructed to avoid all keydown handling of Escape in PB.

Fix in 77ea8cc

@rlisahuang rlisahuang added tmpfix PB and removed urgent LEAP Anything specifically about LEAP. labels Mar 3, 2023
@rlisahuang rlisahuang removed their assignment Mar 10, 2023
@rlisahuang rlisahuang removed the bug Something isn't working label Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
PB tmpfix web
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rlisahuang