Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake code #4

Open
bast opened this issue Jan 21, 2022 · 6 comments
Open

Update CMake code #4

bast opened this issue Jan 21, 2022 · 6 comments

Comments

@bast
Copy link

bast commented Jan 21, 2022

I noticed that the CMake code has not been touched in many years.

I could update that part (since I need it for my own work also) if there is interest in that. But I first wanted to check here before working on such a pull request.

@mikebedington
Copy link
Member

There probably many parts that haven't been touched in years :-p But yes I think it would be good and might help to keep us up to date with newer clusters (compatibility with a less jurrasic-era petsc would be good on that front too). Only concern is merging in later changes from umassd. Which bits are you looking at?

@bast
Copy link
Author

bast commented Jan 21, 2022

OK I will work on that. I am also a bit worried about diverging w.r.t. upstream. I am helping my researcher colleagues who are using the code but struggle with building.

@mikebedington
Copy link
Member

Sounds good!

@bast
Copy link
Author

bast commented Feb 18, 2022

The rewritten CMake code is currently here: https://github.com/bast/uk-fvcom/tree/akvaplan-updated-cmake.

I will at some point send a PR but my goal is to apply the patch to FVCOM branch but so far I have only tested it with the akvaplan branch.

@bast
Copy link
Author

bast commented Feb 18, 2022

One problem in my example branch is that it only builds FVCOM as a library and not as an executable. I am working on that.

@bast
Copy link
Author

bast commented Feb 18, 2022

Now it builds also the executable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants