-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CMake code #4
Comments
There probably many parts that haven't been touched in years :-p But yes I think it would be good and might help to keep us up to date with newer clusters (compatibility with a less jurrasic-era petsc would be good on that front too). Only concern is merging in later changes from umassd. Which bits are you looking at? |
OK I will work on that. I am also a bit worried about diverging w.r.t. upstream. I am helping my researcher colleagues who are using the code but struggle with building. |
Sounds good! |
The rewritten CMake code is currently here: https://github.com/bast/uk-fvcom/tree/akvaplan-updated-cmake. I will at some point send a PR but my goal is to apply the patch to |
One problem in my example branch is that it only builds FVCOM as a library and not as an executable. I am working on that. |
Now it builds also the executable. |
I noticed that the CMake code has not been touched in many years.
I could update that part (since I need it for my own work also) if there is interest in that. But I first wanted to check here before working on such a pull request.
The text was updated successfully, but these errors were encountered: