Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the content area title changeable #43

Open
2 tasks
UPLYNXED opened this issue Apr 17, 2024 · 0 comments
Open
2 tasks

Make the content area title changeable #43

UPLYNXED opened this issue Apr 17, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request low priority Not high on the to-do list refactor Feature requires a refactor/rework

Comments

@UPLYNXED
Copy link
Owner

  • Support changing per loop
  • Support search queries reflecting in the title
@UPLYNXED UPLYNXED added enhancement New feature or request refactor Feature requires a refactor/rework low priority Not high on the to-do list labels Apr 17, 2024
@UPLYNXED UPLYNXED added this to the Public Stable Version milestone Apr 17, 2024
@UPLYNXED UPLYNXED self-assigned this Apr 17, 2024
UPLYNXED pushed a commit that referenced this issue Apr 17, 2024
- Search now supports multiple terms, separated by spaces, or grouped as a phrase with quotes. [see #40]
- Refactored searchTweets to avoid checking if tweet exists in results for every single matching tweet

- Implemented first version of proper tweets filtering (in the object before it goes to the template) [closes #3] [see #4]
- Refactored how the filters object in tweet objects is structured to allow for more complex filtering
- Added discardAds() to remove ads from the tweet loop [closed #41]
- Enabled all filters & their options and added a few new options.

- Added processUsers() to clean up user objects and add former usernames (if defined in config) [see #9]
- User mentions of former usernames are now replaced with current ones (if defined in config) [see #9]
- Added resolveUserObject function to find a user object from a given username or name

- Implemented first version of tweet reply threading [see #28]
- Fixed the replies prototype method for tweets

- media_replacements now also stores the last succesfully resolved media URL which is used to avoid re-resolving the same media again [see #42]
- Added support for saving/loading media_replacements to localStorage to cache last successful media URLs [closes #42]
- Added unavatar.io as a fallback for user avatars to grab their latest avatar if not archived.

- Fixed popovers only working on the first page load and firing way too many broken events [closes #29]
- Adjusted popover positioning, as well as the arrow position. Popovers now also hide when target is off-screen. [closes #20]

- Added rudimentary functionality to change the content section title. [see #43]

- No longer tries to load more tweets when the tweet list is empty or less than the limit
- Refactored tweets_object, `loaded_tweets` now contains and reflects all rendered tweets, `current_loop.tweet_list` contains a working copy of the tweets to be displayed (for filtering, etc.). [see #3]

Known issues:
- Popovers are still a bit buggy and sometimes don't show up on second interaction
- Popovers can mess with scrolling in scrollboxes (e.g. relevant users list) and cause full page scrolling instead.
- Filters are still global and not per loop, so they can conflict (e.g. filtering out media, and then switching to the media loop)
- Threaded replies are not yet filtered from the overall conversation and will show up multiple times on the page.
- url_path prototype method is pointing to twitter.com urls when local urls are possible. Old design decision, needs to be re-evaluated.
- Conditions for showing the "including past cutoff date" filter on threads appears to be inverted.
UPLYNXED added a commit that referenced this issue Apr 17, 2024
- Search now supports multiple terms, separated by spaces, or grouped as a phrase with quotes. [see #40]
- Refactored searchTweets to avoid checking if tweet exists in results for every single matching tweet

- Implemented first version of proper tweets filtering (in the object before it goes to the template) [closes #3] [see #4]
- Refactored how the filters object in tweet objects is structured to allow for more complex filtering
- Added discardAds() to remove ads from the tweet loop [closed #41]
- Enabled all filters & their options and added a few new options.

- Added processUsers() to clean up user objects and add former usernames (if defined in config) [see #9]
- User mentions of former usernames are now replaced with current ones (if defined in config) [see #9]
- Added resolveUserObject function to find a user object from a given username or name

- Implemented first version of tweet reply threading [see #28]
- Fixed the replies prototype method for tweets

- media_replacements now also stores the last succesfully resolved media URL which is used to avoid re-resolving the same media again [see #42]
- Added support for saving/loading media_replacements to localStorage to cache last successful media URLs [closes #42]
- Added unavatar.io as a fallback for user avatars to grab their latest avatar if not archived.

- Fixed popovers only working on the first page load and firing way too many broken events [closes #29]
- Adjusted popover positioning, as well as the arrow position. Popovers now also hide when target is off-screen. [closes #20]

- Added rudimentary functionality to change the content section title. [see #43]

- No longer tries to load more tweets when the tweet list is empty or less than the limit
- Refactored tweets_object, `loaded_tweets` now contains and reflects all rendered tweets, `current_loop.tweet_list` contains a working copy of the tweets to be displayed (for filtering, etc.). [see #3]

Known issues:
- Popovers are still a bit buggy and sometimes don't show up on second interaction
- Popovers can mess with scrolling in scrollboxes (e.g. relevant users list) and cause full page scrolling instead.
- Filters are still global and not per loop, so they can conflict (e.g. filtering out media, and then switching to the media loop)
- Threaded replies are not yet filtered from the overall conversation and will show up multiple times on the page.
- url_path prototype method is pointing to twitter.com urls when local urls are possible. Old design decision, needs to be re-evaluated.
- Conditions for showing the "including past cutoff date" filter on threads appears to be inverted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Not high on the to-do list refactor Feature requires a refactor/rework
Projects
Status: 📑 To-do
Development

No branches or pull requests

1 participant