Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memoising is unsuitable for PC-relative instructions. #11

Closed
katrinafyi opened this issue Mar 1, 2024 · 0 comments · Fixed by #17
Closed

memoising is unsuitable for PC-relative instructions. #11

katrinafyi opened this issue Mar 1, 2024 · 0 comments · Fixed by #17

Comments

@katrinafyi
Copy link
Member

katrinafyi commented Mar 1, 2024 •
edited
Loading

e.g. adrp x0, #8192 bytes 000000D0 opnum 0xd0000000

the semantics will be recorded for one instruction at a particular address and incorrectly re-used if that opcode reoccurs. i think we have been lucky so far, but this is quite unfortunate.

#5
@katrinafyi katrinafyi changed the title memoising of semantics is unsuitable for PC-relative instructions. memoising is unsuitable for PC-relative instructions. Mar 1, 2024
@katrinafyi katrinafyi linked a pull request Jul 10, 2024 that will close this issue
Major refactor #17
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Major refactor UQ-PAC/gtirb-semantics
1 participant
@katrinafyi