482 create tadamonitoringlocationidentifier in tada autoclean #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using TADA.MonitoringLocationIdentifier in TADA_FindNearbySites, changes made up through line 837
Update TADA_FindNearby to use TADA.MonitoringLocationIdentifier not MonitoringLocationIdentifier
Switch from MonitoringLocationIdentifier to TADA.MonitoringLocationIdentifier in depth profile functions, including documentation updates
Switched to using TADA.MonitoringLocationIdentifier in relevant functions
…er-in-tada_autoclean
Added TADA.MonitoringLocationName to TADA_Autoclean
Updated TADA_FindNearby to take into account org, meta data selection options, and create TADA.MonitoringLocationName
This was
linked to
issues
Sep 10, 2024
updated to use TADA.MonitoringLocationIdentifier for grouping and joining
Use TADA.MonitoringLocationIdentifier and TADA.MonitoringLocationName
Added identifier arg to TADA_OverviewMap
Updated overviewmap to include identifier param for wqp vs tada monitoring location data, added TADA.MonitoringLocationTypeName to autoclean, updated example data
TADA_GetUniqueNearbySites updates
Update TADA_FlaggedSites
Analysis filter bug fix
Potential fix for Field table bug
|
This is ready for review. If you spot any additional places where I have not made the MonitoringLocationIdentifier -> TADA.MonitoringLocationIdentitifer switch. |
|
Should any of the geospatial functions refer to TADA.MonitoringLocationIdentifier? Or should these be kept as MonitoringLocationIdentifier? |
I included a few spots where TADA.MonitoringLocationIdentifier or TADA.MonitoringLocationType may be appropriate but if they don't see appropriate for change, please feel free to revert.
Updates to nearby sites
…er-in-tada_autoclean
…er-in-tada_autoclean
…er-in-tada_autoclean
…er-in-tada_autoclean
|
Closing this PR. Will resubmit when I have a working draft involving the geospatial components we've discussed in Team meetings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am still working on updating functions which rely on either "MonitoringLocationIdentifier" or "MonitoringLocationName" to use the TADA columns instead. However, the updates to TADA_FindNearbySites are working on test data sets, so any thoughts on how to improve those would be helpful. I have not incorporated using the AlternateMonitoringLocationID field as that isn't currently a field we include in the TADA df.
Should TADA_OverviewMap switch to using TADA.MonitoringLocationIdentifier so that grouped sites show up with only one marker on the map? Or should I add a param so that users can select whether the original or TADA monitoring location are mapped?