Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSS that is causing left-side of TADA Shiny app to touch left-window margin #198

Open
5 tasks
JamesBisese opened this issue Jan 14, 2025 · 0 comments
Open
5 tasks
Assignees

Comments

@JamesBisese
Copy link
Collaborator

JamesBisese commented Jan 14, 2025

Describe the bug

A CSS directive is causing the TADA Shiny app to touch the left-side of the window.

image

To Reproduce

Steps to reproduce the behavior:

1. Go to 'TADA Shiny App'

2. Click on tab '1. Load'

3. Look at the page

4. See error

View attached image.

If applicable, include code to reproduce the behavior:

error is caused by css grid.less
.row {
    margin-right: -15px;
    margin-left: -15px;
}

Expected behavior

Page should not have content touching the window frame

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

Reminders for TADA contributors addressing this issue

Bug fixes should include the following work:

  • Create or edit the code.

fix should be in 'styles.css' or added into app_ui.R in the css definition. Need to make sure this overrides grid.less.

.row {
    margin-right: 0px;
    margin-left: 0px;
}
  • Document all code using line/inline and/or multi-line/block comments
    to describe what is does.

  • Create or edit tests in tests/testthat folder to help prevent and/or
    troubleshoot potential future issues.

  • If your code edits impact other functionality in the shiny
    app, ensure those are updated as well.

  • Run styler::style_pkg(), devtools::document(), and devtools::check()
    and address any new notes or issues before creating a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants