Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If an invalid parameter is passed it still becomes 'set' in the parameter list #8

Open
JeffreyMinucci opened this issue Sep 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@JeffreyMinucci
Copy link
Collaborator

If in invalid parameter is passed to the model, an exception is raised as expected, but the invalid parameter still gets added to the parameter list. As a result, subsequent attempts to set parameters always fail as the entire saved parameter list is checked each time.

Possible solution: check the validity of newly passed parameters only (both via load_input_file() and set_parameters()) and do not set any parameters if any are invalid. Update the exception message to be clear that no parameters were set.

@JeffreyMinucci JeffreyMinucci added the bug Something isn't working label Sep 27, 2024
@JeffreyMinucci JeffreyMinucci self-assigned this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant