From 71914297f5f11793349c66565ac7cc6ef440acf6 Mon Sep 17 00:00:00 2001 From: Jesse Ross Date: Thu, 26 May 2022 11:03:14 -0700 Subject: [PATCH] remove Lindsay from instructions --- .github/issues_to_create/issue_08.md | 2 +- .github/issues_to_create/issue_14.md | 2 +- .github/issues_to_create/issue_16.md | 2 +- README.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/issues_to_create/issue_08.md b/.github/issues_to_create/issue_08.md index b81a48b..0ebdf38 100644 --- a/.github/issues_to_create/issue_08.md +++ b/.github/issues_to_create/issue_08.md @@ -12,7 +12,7 @@ For now, we will discuss how to open a pull request. 2. Before your pull request is actually created, you should verify that you are requesting the correct changes be merged with the correct repository. For now, we are not working with branches, so don't worry about the fields that say "main". However, you should verify that the `base repository` is set to the project canonical repo (`USGS-R/ds-gitflows-[username]` in this case) and that the `head repository` is set to your fork (`[username]/ds-gitflows-[username]`). You also need to verify the commits lists. It should list the two that you just created. 3. When you have checked those things, you can click the green "Create pull request" button. 4. You still haven't made the pull request yet - one more step. You now need to title your pull request and add a description about your changes. I believe this was discussed earlier but if you need a refresher, [here is an article about some common best practices when it comes to PRs](https://www.atlassian.com/blog/git/written-unwritten-guide-pull-requests). In your description, make sure to reference this issue by typing `#[issue number]`. -5. Once you add a title and description, click the cog next to the `Reviewers` feature on the right bar and select @lindsayplatt as the reviewer from the drop-down menu. **Note - if you do not have the option to add a reviewer, do step 6 and then add the reviewer after.** +5. Once you add a title and description, click the cog next to the `Reviewers` feature on the right bar and select your course contact as the reviewer from the drop-down menu. **Note - if you do not have the option to add a reviewer, do step 6 and then add the reviewer after.** 6. Now you are ready - click "Create pull request" You have now successfully created a PR! Wait for your PR to be reviewed and merged. Once your PR has been merged, close this issue and move on to the next one. diff --git a/.github/issues_to_create/issue_14.md b/.github/issues_to_create/issue_14.md index a03db91..15e7290 100644 --- a/.github/issues_to_create/issue_14.md +++ b/.github/issues_to_create/issue_14.md @@ -10,7 +10,7 @@ We are now ready to push our local changes (including the resolved merge conflic 1. Before your pull request is actually created, you need to verify that you are requesting the correct changes be merged with the correct repository. Remember, we are not working with branches, so don't worry about the fields that say "main". However, you should verify that the `base repository` is set to the project canonical repo (`USGS-R/ds-gitflows-[username]`) and that the `head repository` is set to your fork (`[username]/ds-gitflows-[username]`). 1. After verifying, click the green "Create pull request" button. 1. Add a title to your pull request and a description about your changes. In your description, make sure to reference this issue by typing `#[issue number]`. -1. Once you add a title and description, click the cog next to the `Reviewers` feature on the right bar and select @lindsayplatt as the reviewer from the drop-down menu. If you do not have the option to add a reviewer, do step 9 and then add the reviewer after. +1. Once you add a title and description, click the cog next to the `Reviewers` feature on the right bar and select your course contact as the reviewer from the drop-down menu. If you do not have the option to add a reviewer, do step 9 and then add the reviewer after. 1. Now, click "Create pull request". You have successfully made a second pull request! Wait for your PR to be reviewed and merged. Once your PR has been merged, close this issue and move on to the next one. diff --git a/.github/issues_to_create/issue_16.md b/.github/issues_to_create/issue_16.md index 083928e..e703c2f 100644 --- a/.github/issues_to_create/issue_16.md +++ b/.github/issues_to_create/issue_16.md @@ -15,6 +15,6 @@ git add .gitignore git commit -m "add downloaded image to gitignore" git push origin main ``` -8. Finally, create a pull request. Make sure to add @lindsayplatt as a reviewer of your PR and reference this issue using `#[issue number]`. Reminder - you can look back at closed issues to follow along with past instructions by clicking "Issues" and then "Closed" on the GitHub page for the canonical repository. +8. Finally, create a pull request. Make sure to add your course contact as a reviewer of your PR and reference this issue using `#[issue number]`. Reminder - you can look back at closed issues to follow along with past instructions by clicking "Issues" and then "Closed" on the GitHub page for the canonical repository. Once you open your PR, wait for it to be reviewed and merged. Once your PR has been merged, close this issue and go to the next one. diff --git a/README.md b/README.md index 07ab993..aec935e 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # USGS Data Science tutorial for Git and GitHub workflow -This template repository contains the issues and starting content to teach the DS fork-and-pull style workflow. For the full experience, it requires someone else (listed as @lindsayplatt in these instructions) to review and merge your pull requests. +This template repository contains the issues and starting content to teach the DS fork-and-pull style workflow. For the full experience, it requires a course contact to review and merge your pull requests. ## I'm a learner