Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically derive input reading frequency from file #33

Open
BramDr opened this issue Feb 29, 2024 · 0 comments
Open

Automatically derive input reading frequency from file #33

BramDr opened this issue Feb 29, 2024 · 0 comments
Labels
enhancement Enhancement request

Comments

@BramDr
Copy link
Contributor

BramDr commented Feb 29, 2024

Currently, the frequency at which input parameters are read from file is hard coded in the model. For example the yearly land-surface inputs:

        # - assumption: annual resolution
        if self.noAnnualChangesInLandCoverParameter == False and self.dynamicIrrigationArea == False and \
          (currTimeStep.timeStepPCR == 1 or currTimeStep.doy == 1):
            msg = 'Read land cover fractions based on the given netcdf file.'```

It would be better for this frequency to be derived from the files themselves, meaning that if a monthly file is given, data is read monthly. Moreover, if the final timestep of the input file is reached, the input data of the final timestep is re-read every year. This is not needed.
@BramDr BramDr added the enhancement Enhancement request label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement request
Projects
None yet
Development

No branches or pull requests

1 participant