Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bonus 💜 reacts #249

Open
ericthelemur opened this issue Apr 16, 2024 · 0 comments
Open

Fix bonus 💜 reacts #249

ericthelemur opened this issue Apr 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ericthelemur
Copy link
Contributor

Apollo currently reacts to messages containing "thanks" (or various alternatives) that are also considered "replies":

  • being a direct reply message or
  • is immediately after an apollo message
  • or when they contain the words apollo and thanks
    This catches a few too many false positives atm, especially when karma is around, so it's worth reducing the frequency a bit.

Some ideas:

  • remove the 3rd condition (seems especially prone to false positives
  • ignore karma messages as part of the immediate reply check (these are usually just going to be a conversation continuing)
    • Simple proxy is ignore any apollo msgs starting with Changes: or containing I have made changes to the following karma item:
@ericthelemur ericthelemur added the bug Something isn't working label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant