Unable to rename groups/"erasers"

[KenLucke]

Application Version

4.8.0

Platform

Mac OS 10.15.7 (Catalina)

Printer

N/A

Reproduction steps

Group some objects
Attempt to rename the object group or support blocker ("eraser") via Mesh Tools > Rename

Actual results

Rename Dialog appears, allows entry, but fails to rename group or support blocker.

Expected results

Should allow all objects - models, support blockers ("erasers"), and groups - to be renamed, for clarity in the Objects List.

claws.3mf.zip

[nallath]

Please report issues with the meshtools plugin with the developer of that plugin: https://github.com/fieldOfView/Cura-MeshTools

[KenLucke]

Thanks, it's hard to find the plugin Github pages.

[nallath]

The marketplace shows the website for most plugins. That's where I got this from.

[fieldOfView]

That's where I got this from.

You had to look it up? For shame!

[nallath]

Psh, you have so much plugins and I had the marketplace open :P

[fieldOfView]

I looked into the issue of renaming groups using the MeshTools plugin, and it turns out that Cura renames the group right back to Group #n here:
https://github.com/Ultimaker/Cura/blob/master/cura/UI/ObjectsModel.py#L150
So I would argue that this is a Cura issue afterall.

Shall I create a PR to make that code a bit more permissive of other names (as long as there is a name), or is there a reason to force the group names to Group #n?

(for reference: the MeshTools issue opened by @KenLucke is here: fieldOfView/Cura-MeshTools#20)

[Ghostkeeper]

Fixed link to where it gets renamed (permalink this time):

Cura/cura/UI/ObjectsModel.py

Line 171 in 4bf440b

all_nodes = self._renameNodes(name_to_node_info_dict)

[Ghostkeeper]

This seems to originate from here: c839bc1

As far as I can tell, the purpose of this is just to make sure the groups have some recognisable/identifiable name, rather than an empty string or all having the same name when groups are created.

If the group names are unique by default, it's fine that they get given other names. So a pull request to fix this would be welcome! Otherwise I'll propose this to the team, but I must say that I don't expect our PO to give this a lot of priority as you might understand.

[fieldOfView]

I'll create a PR that does something smart with the group names then.