Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Changing font causes display of placeholder text for non-alphanumeric languages #839

Open
odeminan opened this issue May 8, 2024 · 3 comments

Comments

@odeminan
Copy link

odeminan commented May 8, 2024

Actual behavior

When changing the lyrics font to the other font choices, Japanese/Korean songs do not display properly and show placeholder text.

Expected behavior

Font should change as expected. Default fonts should include multiple character sets.

Steps to reproduce

  1. Open the ultrastardx.exe
  2. Tools > Options > Lyrics
  3. Change font to Free Sans.
  4. Exit option menu.
  5. Sing song with Japanese/Korean language characters in use.

Details

  • USDX version: 2024.3.0
  • Operating System + version: Windows 10 Pro 64bit
@bohning
Copy link
Collaborator

bohning commented May 8, 2024

Free Sans simply does not contain Japanese/Korean character sets. So if you want to sing (non-romanized) Asian songs, you're (currently) stuck with Noto Sans.

@odeminan
Copy link
Author

odeminan commented May 8, 2024

Would it make sense to check upon load of the song if the font is supported by the character set in the song? If unsupported switch to the available supported font.
Or post a warning when changing the font that only some languages are supported?

@bohning
Copy link
Collaborator

bohning commented May 11, 2024

Sure would make sense. Feel free to implement it and open a pull request =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants