Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XenForo 2.0 Support #19

Open
DiWorm opened this issue Dec 9, 2017 · 10 comments
Open

XenForo 2.0 Support #19

DiWorm opened this issue Dec 9, 2017 · 10 comments

Comments

@DiWorm
Copy link

DiWorm commented Dec 9, 2017

Hello again,

Will be version with XenForo 2.0 support?

@gabarba
Copy link
Contributor

gabarba commented Dec 13, 2017

It will be in the future but I have not had a chance to even look at Xenforo 2 yet or Laravel 5.5 for that matter.

The authentication part should be easy enough I would assume the only issue will be how templates are rendered in Xenforo 2.

I probably won't get around to looking at this until a few months into the new year as I am currently working on a large Magento 2 conversion.

@susl16c
Copy link

susl16c commented Jun 27, 2018

Tell me please, I'm also interested in integration with XF 2.0. Will you implement this?

@JeremyHutchings
Copy link

@susl16c

Have you tested it with 2.0 ? What are the issues you saw ?

@susl16c
Copy link

susl16c commented Jun 27, 2018

No, I just read the answer above and you wrote there that look

@JeremyHutchings
Copy link

I guess we should test it first, it could just work !

@alfio8788
Copy link

Does not work in XF2...

The loader is no more in library/ but in src/ fixing the path variable in the bridge does not solve it:

Symfony \ Component \ Debug \ Exception \ FatalThrowableError (E_ERROR) Class 'XenForo_Autoloader' not found

This is going to need some rewriting

@gabarba
Copy link
Contributor

gabarba commented Oct 1, 2018

This library currently does not support XF2 only Xenforo 1

@alfio8788
Copy link

alfio8788 commented Oct 1, 2018

This library currently does not support XF2 only Xenforo 1

That is the reason i created a fork and started an adaptation (sadly all the classes names changed between XF1 and XF2 and making it compatible with both versions is more work than just making it compatible with either version (lot's of if/else involved in the code...), for this reason i decided to just make it compatible with XF2 and drop the compatibility with XF1

@gabarba
Copy link
Contributor

gabarba commented Oct 2, 2018

@alfio8788 Thanks for taking enough of an interest to take on that project. At this time I have recently switched jobs and I'm no longer working with PHP primarily, and specifically Xenforo for the time being. I actually have been unable to even look at the XF2 platform in general. As you noted it probably wouldn't be worth the time to make the library compatible with both XF1 and XF2. But if you were going to I would probably use some sort of class map and or interface abstraction and load the corresponding class map depending on the version of Xenforo that is being used.

@alfio8788
Copy link

Sorry for the late reply

I have a job as well and not much time to develop this in a short time, in my case it's for a fan site we are remaking and we wanted to develop our own cms and integrate it with xenforo (at the moment we are stuck with wordpress+xenforo with xenword as a bridge).

Xenforo 2 is a total rewrite and has nothing in common with version 1 if not the database structure and having pretty few time each day i am unable to give it the required attention at the moment...i am going through it like a slowpoke and it's frustrating cause every time you lose more time opening the editor and remember what you were doing than actually making it work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants