From 610b1fb0bba6affca7263d90264ccba2b354f6de Mon Sep 17 00:00:00 2001 From: Benjamin Root Date: Tue, 7 May 2024 14:31:57 -0400 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Tara Drwenski --- cdm/misc/src/test/java/ucar/nc2/geotiff/TestIFDEntry.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/cdm/misc/src/test/java/ucar/nc2/geotiff/TestIFDEntry.java b/cdm/misc/src/test/java/ucar/nc2/geotiff/TestIFDEntry.java index fdd3873944..8c8ab2a8d2 100644 --- a/cdm/misc/src/test/java/ucar/nc2/geotiff/TestIFDEntry.java +++ b/cdm/misc/src/test/java/ucar/nc2/geotiff/TestIFDEntry.java @@ -11,14 +11,12 @@ import org.junit.runners.Parameterized; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import java.io.*; import java.lang.ReflectiveOperationException; import java.lang.invoke.MethodHandles; import java.lang.reflect.Method; import java.nio.ByteBuffer; import java.nio.ByteOrder; import java.util.ArrayList; -import java.util.Collections; import java.util.List; /** @@ -30,9 +28,8 @@ @RunWith(Parameterized.class) public class TestIFDEntry { private static final Logger logger = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); - public IFDEntry ifd; - // Because we are dealing with reflection - public int testValue; + private final IFDEntry ifd; + private final int testValue; @Parameterized.Parameters(name = "{0}_{1}") public static List getTestParameters() {