Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdm-radial: Parsing issues with radar files from IDEAM Colombia #1292

Closed
1 task done
michaeldiener opened this issue Jan 21, 2024 · 4 comments
Closed
1 task done

cdm-radial: Parsing issues with radar files from IDEAM Colombia #1292

michaeldiener opened this issue Jan 21, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@michaeldiener
Copy link
Contributor

Versions impacted by the bug

5.3 and onwards

What went wrong?

Loading Sigmet/IRIS files from IDEAM Colombia fail due to various ArrayIndexOutOfBoundsExceptions in ucar.nc2.iosp.sigmet.SigmetVolumeScan.

Attached is an example file from the Barrancabermeja radar station (License CC BY 4.0).

I have already investigated the source of the bug. The main issue is in ucar.nc2.iosp.sigmet.SigmetIOServiceProvider.readRecordsHdr(...). The variable nparams is not complete. I will prepare a Pull Request as well with the needed fixes.

BAR230510062107.RAW2XYJ.zip

Relevant stack trace

java.lang.ArrayIndexOutOfBoundsException: Index -8252 out of bounds for length 6
	at ucar.nc2.iosp.sigmet.SigmetVolumeScan.<init>(SigmetVolumeScan.java:222)
	at ucar.nc2.iosp.sigmet.SigmetIOServiceProvider.open(SigmetIOServiceProvider.java:132)
	at ucar.nc2.NetcdfFile.<init>(NetcdfFile.java:1610)
	at ucar.nc2.NetcdfFiles.open(NetcdfFiles.java:750)
	at ucar.nc2.NetcdfFiles.openInMemory(NetcdfFiles.java:698)

Relevant log messages

No response

If you have an example file that you can share, please attach it to this issue.

If so, may we include it in our test datasets to help ensure the bug does not return once fixed?
Note: the test datasets are publicly accessible without restriction.

Yes

Code of Conduct

  • I agree to follow the UCAR/Unidata Code of Conduct
@michaeldiener michaeldiener added the bug Something isn't working label Jan 21, 2024
@michaeldiener
Copy link
Contributor Author

There are more issues with files from other Colombian stations and so I'm still investigating and preparing a PR. Seems to be different bugs this time and so I'll probably file another or more reports. Might take a few days until I get to the bottom of this.

@tdrwenski
Copy link
Member

Thank you for reporting and investigating this! Let us know if you need any assistance from us.

@michaeldiener
Copy link
Contributor Author

In the end it was not only the readRecordsHdr method but also missing support for all data types instead of just 5. PR uploaded.

@michaeldiener
Copy link
Contributor Author

My fixes have been merged: #1295

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants