Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The description of the departureTime and arrivalTime in tripSearchCriteria should indicate one is mandatory #664

Open
nixxus1030 opened this issue Aug 20, 2024 · 1 comment · May be fixed by #666
Open

The description of the departureTime and arrivalTime in tripSearchCriteria should indicate one is mandatory #664

nixxus1030 opened this issue Aug 20, 2024 · 1 comment · May be fixed by #666
Assignees
@nixxus1030
Labels
documentation Improvements or additions to documentation
Milestone
3.4.0

Comments

@nixxus1030
Copy link
Collaborator

nixxus1030 commented Aug 20, 2024 •
edited
Loading

At the moment there is no explicit indication that when using tripSearchCriteria, at least one of departureTime and arrivalTime have to be filled in.

Proposal is to adapt the description of the attribute to specify this
@nixxus1030 nixxus1030 added documentation Improvements or additions to documentation improvements New feature or request and removed improvements New feature or request labels Aug 20, 2024
@nixxus1030 nixxus1030 modified the milestones: 3.3.0, 3.4.0, 3.3.1 Aug 20, 2024
@nixxus1030 nixxus1030 self-assigned this Aug 20, 2024
@jspetrak jspetrak modified the milestones: 3.3.1, 3.4.0 Aug 20, 2024
jspetrak added a commit that referenced this issue Aug 22, 2024
@jspetrak
#664 TripSearchCriteria - only one of departure/arrival time may be p…
12add58 
…rovided
@jspetrak
Copy link
Collaborator

@nixxus1030 It was partially described in the openapi spec., but I pulled a change to have a clearer definition. Please review.

@jspetrak jspetrak linked a pull request Aug 22, 2024 that will close this issue
#664 TripSearchCriteria - only one of departure/arrival time may be p… #666
Open
jspetrak added a commit that referenced this issue Aug 30, 2024
@jspetrak
#664 TripSearchCriteria - only one of departure/arrival time may be p…
3b37ac9 
…rovided
jspetrak added a commit that referenced this issue Aug 30, 2024
@jspetrak
#664 TripSearchCriteria - only one of departure/arrival time may be p…
ca144df 
…rovided
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nixxus1030 nixxus1030

Labels
documentation Improvements or additions to documentation
Projects
OSDM Specification
Status: In review
Milestone
3.4.0
2 participants
@jspetrak @nixxus1030